Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/actions/benchmark/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Benchmark Execution
runs:
using: 'composite'
steps:
- name: Install dependencies
uses: ./.github/actions/pnpm-setup

- name: Install playwright dependencies and browsers
run: pnpm exec playwright install --with-deps chromium
shell: bash
working-directory: packages/tools/benchmark-tests

- name: Build required packages
run: pnpm build:deps
shell: bash
working-directory: packages/tools/benchmark-tests

- name: Run benchmark tests
run: pnpm test-benchmark
shell: bash
working-directory: packages/tools/benchmark-tests
64 changes: 64 additions & 0 deletions .github/workflows/benchmark.monitoring.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
name: Benchmark-Monitoring

on:
push:
branches:
- develop
workflow_dispatch:

concurrency:
group: 'workflow-${{ github.workflow }}-${{ github.ref }}'
cancel-in-progress: true

jobs:
benchmark:
runs-on: ubuntu-latest
steps:
- name: Create GitHub App Token
uses: actions/create-github-app-token@v2
id: app-token
with:
app-id: ${{ secrets.APP_ID }}
private-key: ${{ secrets.PRIVATE_KEY }}

- name: Get GitHub App User ID
id: get-user-id
run: echo "user-id=$(gh api "/users/${{ steps.app-token.outputs.app-slug }}[bot]" --jq .id)" >> "$GITHUB_OUTPUT"
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}

- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false

- name: Install and execute benchmark
uses: ./.github/actions/benchmark

- name: Remove husky
run: rm -rf .husky
shell: bash

- name: Store benchmark result
uses: rhysd/github-action-benchmark@v1
with:
alert-threshold: 10%
auto-push: true
fail-threshold: 25%
gh-pages-branch: benchmarks
github-token: ${{ secrets.GITHUB_TOKEN }}
output-file-path: packages/tools/benchmark-tests/benchmark-result.json
tool: customSmallerIsBetter

- name: Copy result as new baseline
run: cp packages/tools/benchmark-tests/benchmark-result.json packages/tools/benchmark-tests/benchmark-baseline.json

- name: Commit and push updated baseline
uses: stefanzweifel/git-auto-commit-action@v5
with:
commit_message: 'chore: update benchmark-baseline.json [ci skip]'
file_pattern: 'packages/tools/benchmark-tests/benchmark-baseline.json'
commit_user_name: '${{ steps.app-token.outputs.app-slug }}[bot]'
commit_user_email: '${{ steps.get-user-id.outputs.user-id }}+${{ steps.app-token.outputs.app-slug }}[bot]@users.noreply.github.com'
push_options: '--force'
46 changes: 46 additions & 0 deletions .github/workflows/benchmark.pr-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Benchmark-PR-Check

on:
pull_request:

concurrency:
group: 'workflow-${{ github.workflow }}-${{ github.ref }}'
cancel-in-progress: true

jobs:
benchmark:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false

- name: Install and execute benchmark
uses: ./.github/actions/benchmark

- name: Load benchmark from target branch
run: |
git fetch origin ${{ github.base_ref }}
git show origin/${{ github.base_ref }}:packages/tools/benchmark-tests/benchmark-baseline.json > packages/tools/benchmark-tests/benchmark-baseline.json || echo "[]" > packages/tools/benchmark-tests/benchmark-baseline.json

- name: Compare benchmark with baseline
run: node scripts/compare-benchmark.mjs
working-directory: packages/tools/benchmark-tests

- name: Find comment
uses: peter-evans/find-comment@v3
id: fc
with:
body-includes: Hydration Benchmark Report
comment-author: 'github-actions[bot]'
issue-number: ${{ github.event.pull_request.number }}

- name: Post PR Comment
uses: peter-evans/create-or-update-comment@v4
with:
body-path: packages/tools/benchmark-tests/benchmark-report.md
comment-id: ${{ steps.fc.outputs.comment-id }}
edit-mode: replace
issue-number: ${{ github.event.pull_request.number }}
6 changes: 3 additions & 3 deletions packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,16 @@
"lint:tsc": "tsc --noemit",
"dev": "cross-env NODE_ENV=development stencil build --prod --watch",
"test": "pnpm test:unit",
"test:e2e": "playwright test",
"test:unit": "cross-env NODE_ENV=test stencil test --spec --json --outputFile dist/jest-test-results.json",
"test:watch": "cross-env NODE_ENV=test stencil test --spec --watchAll",
"test:e2e": "playwright test",
"postpack": "mv package.bak.json package.json",
"prepack": "npm run build && cp package.json package.bak.json && rimraf dist/collection dist/kolibri/assets/@leanup dist/types/assets/@leanup && node scripts/anonymous.js && node scripts/minify.js",
"xunused": "knip"
},
"dependencies": {
"@floating-ui/dom": "1.6.13",
"adopted-style-sheets": "1.1.8",
"adopted-style-sheets": "1.1.9-rc.17",
"clsx": "2.1.1",
"color-convert": "2.0.1",
"color-rgba": "2.4.0",
Expand Down Expand Up @@ -134,7 +134,7 @@
"typescript": "5.8.2"
},
"peerDependencies": {
"adopted-style-sheets": "1.1.8"
"adopted-style-sheets": "1.1.9-rc.17"
},
"files": [
"assets",
Expand Down
1 change: 0 additions & 1 deletion packages/components/stencil.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ const TAGS = [
'kol-skip-nav',
'kol-spin',
'kol-split-button',
'kol-table-settings-wc',
'kol-table-stateful',
'kol-table-stateless',
'kol-tabs',
Expand Down
44 changes: 2 additions & 42 deletions packages/samples/angular/.gitignore
Original file line number Diff line number Diff line change
@@ -1,42 +1,2 @@
# See http://help.github.com/ignore-files/ for more about ignoring files.

# Compiled output
/dist
/tmp
/out-tsc
/bazel-out

# Node
/node_modules
npm-debug.log
yarn-error.log

# IDEs and editors
.idea/
.project
.classpath
.c9/
*.launch
.settings/
*.sublime-workspace

# Visual Studio Code
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json
.history/*

# Miscellaneous
/.angular/cache
.sass-cache/
/connect.lock
/coverage
/libpeerconnection.log
testem.log
/typings

# System files
.DS_Store
Thumbs.db
.angular
/src/assets/
7 changes: 7 additions & 0 deletions packages/samples/angular/.knip.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"$schema": "https://unpkg.com/knip@5/schema.json",
"entry": ["src/main.ts"],
"ignore": [],
"ignoreDependencies": ["@public-ui/angular-v17", "@public-ui/components", "@public-ui/themes", "@tailwindcss/postcss", "adopted-style-sheets"],
"project": ["src/**/*.{js,ts}"]
}
4 changes: 0 additions & 4 deletions packages/samples/angular/.vscode/extensions.json

This file was deleted.

20 changes: 0 additions & 20 deletions packages/samples/angular/.vscode/launch.json

This file was deleted.

42 changes: 0 additions & 42 deletions packages/samples/angular/.vscode/tasks.json

This file was deleted.

19 changes: 6 additions & 13 deletions packages/samples/angular/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
"projects": {
"angular": {
"projectType": "application",
"schematics": {
"@schematics/angular:component": {
"style": "scss"
}
},
"root": "",
"sourceRoot": "src",
"prefix": "app",
Expand All @@ -22,9 +17,8 @@
"browser": "src/main.ts",
"polyfills": ["zone.js"],
"tsConfig": "tsconfig.app.json",
"inlineStyleLanguage": "scss",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["src/styles.scss"],
"styles": ["src/styles.css"],
"scripts": []
},
"configurations": {
Expand Down Expand Up @@ -74,16 +68,15 @@
"options": {
"polyfills": ["zone.js", "zone.js/testing"],
"tsConfig": "tsconfig.spec.json",
"inlineStyleLanguage": "scss",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["src/styles.scss"],
"styles": ["src/styles.css"],
"scripts": []
}
}
}
}
},
"cli": {
"analytics": false
}
},
"cli": {
"analytics": false
}
}
Loading
Loading