Skip to content

fix(icon): set font-size to inherit to override codicons font size#7944

Merged
deleonio merged 2 commits intodevelopfrom
feature/fix-icon-size
Jun 20, 2025
Merged

fix(icon): set font-size to inherit to override codicons font size#7944
deleonio merged 2 commits intodevelopfrom
feature/fix-icon-size

Conversation

@laske185
Copy link
Copy Markdown
Contributor

@laske185 laske185 commented Jun 20, 2025

This pull request introduces a small but important change to the style.scss file for the icon component. It ensures that icons inherit the font size from their parent elements, overriding the fixed font size previously applied by codicon.


The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@laske185 laske185 requested a review from deleonio June 20, 2025 10:22
@laske185 laske185 changed the title fix(icon): set font-size to inherit to overwrite codicons font size fix(icon): set font-size to inherit to override codicons font size Jun 20, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2025

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-form 28.3ms 35.6ms -20.5%
kol-table-stateless 365ms 437ms -16.5%
kol-input-color 70.3ms 81.9ms -14.2%
kol-abbr 17.1ms 19.8ms -13.6%
kol-drawer 22.4ms 25.6ms -12.5%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-quote 21.7ms 19ms +14.2% 🔻
kol-card 24.9ms 22.6ms +10.2% 🔻
kol-input-number 61ms 56.1ms +8.7%
kol-alert 112.6ms 105.9ms +6.3%
kol-tree-item 67.2ms 64ms +5%
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 17.1ms 19.8ms -13.6%
kol-accordion 129.2ms 131ms -1.4%
kol-alert 112.6ms 105.9ms +6.3%
kol-avatar 26ms 26.9ms -3.3%
kol-badge 62.8ms 70.1ms -10.4%
kol-breadcrumb 97.3ms 97.6ms -0.3%
kol-button 60.3ms 63ms -4.3%
kol-button-link 51ms 50.7ms +0.6%
kol-card 24.9ms 22.6ms +10.2% 🔻
kol-details 129.2ms 134.9ms -4.2%
kol-drawer 22.4ms 25.6ms -12.5%
kol-form 28.3ms 35.6ms -20.5%
kol-heading 20.2ms 21.5ms -6%
kol-icon 67.3ms 65.1ms +3.4%
kol-image 18.5ms 19.3ms -4.1%
kol-input-checkbox 135.3ms 141.3ms -4.2%
kol-input-color 70.3ms 81.9ms -14.2%
kol-input-date 69.2ms 70.3ms -1.6%
kol-input-email 56ms 62.5ms -10.4%
kol-input-file 92.1ms 93.7ms -1.7%
kol-input-number 61ms 56.1ms +8.7%
kol-input-password 50.3ms 51.6ms -2.5%
kol-input-radio 56.2ms 56.5ms -0.5%
kol-input-text 53.6ms 59.3ms -9.6%
kol-link 49.7ms 49.8ms -0.2%
kol-link-button 58.7ms 56.5ms +3.9%
kol-modal 19.8ms 20.5ms -3.4%
kol-nav 30.8ms 33.9ms -9.1%
kol-pagination 425ms 423.8ms +0.3%
kol-popover-button 69.2ms 71.3ms -2.9%
kol-progress 29.9ms 32.8ms -8.8%
kol-quote 21.7ms 19ms +14.2% 🔻
kol-select 116.7ms 117.1ms -0.3%
kol-skip-nav 21.1ms 23.6ms -10.6%
kol-spin 23.8ms 24.2ms -1.7%
kol-split-button 169.2ms 174.7ms -3.1%
kol-table-stateful 365.6ms 374.7ms -2.4%
kol-table-stateless 365ms 437ms -16.5%
kol-tabs 30.1ms 32.3ms -6.8%
kol-textarea 51.5ms 54.1ms -4.8%
kol-toolbar 31.7ms 36ms -11.9%
kol-tree 24.8ms 26.5ms -6.4%
kol-tree-item 67.2ms 64ms +5%
kol-version 149.4ms 154.8ms -3.5%

@deleonio deleonio merged commit de3d02d into develop Jun 20, 2025
11 checks passed
@deleonio deleonio deleted the feature/fix-icon-size branch June 20, 2025 11:10
@publicuibot publicuibot Bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants