Skip to content

remove button row in input scenarios#8030

Merged
deleonio merged 2 commits intodevelopfrom
feature/entferne-buttonreihe-aus-react-beispielen
Jul 15, 2025
Merged

remove button row in input scenarios#8030
deleonio merged 2 commits intodevelopfrom
feature/entferne-buttonreihe-aus-react-beispielen

Conversation

@laske185
Copy link
Copy Markdown
Contributor

@laske185 laske185 commented Jul 15, 2025

Summary

  • show form buttons only when needed
  • drop buttons for all input samples

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

Copilot AI review requested due to automatic review settings July 15, 2025 07:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new showButtons prop to FormWrap to conditionally render form action buttons and updates all basic input/sample components to hide their buttons.

  • Add showButtons prop with default true to FormWrap
  • Wrap button row in FormWrap with a showButtons check
  • Pass showButtons={false} in all sample basic.tsx files to remove buttons

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/samples/react/src/components/textarea/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/single-select/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/select/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-text/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-range/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-radio/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-password/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-number/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-file/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-email/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-date/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-color/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-checkbox/switch.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-checkbox/button.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/input-checkbox/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/combobox/basic.tsx Hide buttons by passing showButtons={false}
packages/samples/react/src/components/FormWrap.tsx Introduce showButtons prop and conditional button rendering
Comments suppressed due to low confidence (2)

packages/samples/react/src/components/FormWrap.tsx:10

  • Add unit or integration tests to verify both states of showButtons (true and false) so the conditional rendering of the button row remains covered.
				{showButtons && (

packages/samples/react/src/components/FormWrap.tsx:5

  • The RefComponent prop is currently typed as any. Consider using React.ComponentType<P> for stronger type safety and clearer component contract.
export const FormWrap = <P,>({ RefComponent: Component, showButtons = true, ...props }: { RefComponent: any; showButtons?: boolean } & Partial<P>) => {

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 15, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 15, 2025

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-heading 17.4ms 21.5ms -19.1%
kol-form 30.1ms 35.6ms -15.4%
kol-input-color 72.1ms 81.9ms -12%
kol-tabs 28.7ms 32.3ms -11.1%
kol-input-radio 50.3ms 56.5ms -11%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-drawer 39.7ms 25.6ms +55.1% 🔻
kol-card 29.7ms 22.6ms +31.4% 🔻
kol-input-number 62.2ms 56.1ms +10.9% 🔻
kol-alert 112.4ms 105.9ms +6.1%
kol-pagination 447.5ms 423.8ms +5.6%
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 17.7ms 19.8ms -10.6%
kol-accordion 131ms 131ms 0%
kol-alert 112.4ms 105.9ms +6.1%
kol-avatar 25.6ms 26.9ms -4.8%
kol-badge 67.1ms 70.1ms -4.3%
kol-breadcrumb 94.8ms 97.6ms -2.9%
kol-button 58.5ms 63ms -7.1%
kol-button-link 53.2ms 50.7ms +4.9%
kol-card 29.7ms 22.6ms +31.4% 🔻
kol-details 130.5ms 134.9ms -3.3%
kol-drawer 39.7ms 25.6ms +55.1% 🔻
kol-form 30.1ms 35.6ms -15.4%
kol-heading 17.4ms 21.5ms -19.1%
kol-icon 66.9ms 65.1ms +2.8%
kol-image 18.1ms 19.3ms -6.2%
kol-input-checkbox 137.4ms 141.3ms -2.8%
kol-input-color 72.1ms 81.9ms -12%
kol-input-date 69ms 70.3ms -1.8%
kol-input-email 57.8ms 62.5ms -7.5%
kol-input-file 97ms 93.7ms +3.5%
kol-input-number 62.2ms 56.1ms +10.9% 🔻
kol-input-password 54.1ms 51.6ms +4.8%
kol-input-radio 50.3ms 56.5ms -11%
kol-input-text 59.5ms 59.3ms +0.3%
kol-link 51.5ms 49.8ms +3.4%
kol-link-button 59.3ms 56.5ms +5%
kol-modal 20ms 20.5ms -2.4%
kol-nav 31.3ms 33.9ms -7.7%
kol-pagination 447.5ms 423.8ms +5.6%
kol-popover-button 74.5ms 71.3ms +4.5%
kol-progress 29.9ms 32.8ms -8.8%
kol-quote 19.2ms 19ms +1.1%
kol-select 117.6ms 117.1ms +0.4%
kol-skip-nav 21.2ms 23.6ms -10.2%
kol-spin 25.5ms 24.2ms +5.4%
kol-split-button 173.1ms 174.7ms -0.9%
kol-table-stateful 368.6ms 374.7ms -1.6%
kol-table-stateless 422.1ms 437ms -3.4%
kol-tabs 28.7ms 32.3ms -11.1%
kol-textarea 50.9ms 54.1ms -5.9%
kol-toolbar 32.5ms 36ms -9.7%
kol-tree 26.1ms 26.5ms -1.5%
kol-tree-item 66ms 64ms +3.1%
kol-version 150.1ms 154.8ms -3%

@laske185 laske185 requested a review from deleonio July 15, 2025 09:42
@deleonio deleonio merged commit f7dacf6 into develop Jul 15, 2025
11 of 12 checks passed
@deleonio deleonio deleted the feature/entferne-buttonreihe-aus-react-beispielen branch July 15, 2025 10:55
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants