remove button row in input scenarios#8030
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new showButtons prop to FormWrap to conditionally render form action buttons and updates all basic input/sample components to hide their buttons.
- Add
showButtonsprop with defaulttruetoFormWrap - Wrap button row in
FormWrapwith ashowButtonscheck - Pass
showButtons={false}in all samplebasic.tsxfiles to remove buttons
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/samples/react/src/components/textarea/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/single-select/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/select/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-text/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-range/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-radio/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-password/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-number/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-file/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-email/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-date/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-color/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-checkbox/switch.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-checkbox/button.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/input-checkbox/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/combobox/basic.tsx | Hide buttons by passing showButtons={false} |
| packages/samples/react/src/components/FormWrap.tsx | Introduce showButtons prop and conditional button rendering |
Comments suppressed due to low confidence (2)
packages/samples/react/src/components/FormWrap.tsx:10
- Add unit or integration tests to verify both states of
showButtons(true and false) so the conditional rendering of the button row remains covered.
{showButtons && (
packages/samples/react/src/components/FormWrap.tsx:5
- The
RefComponentprop is currently typed asany. Consider usingReact.ComponentType<P>for stronger type safety and clearer component contract.
export const FormWrap = <P,>({ RefComponent: Component, showButtons = true, ...props }: { RefComponent: any; showButtons?: boolean } & Partial<P>) => {
Contributor
|
Netlify Draft Deployment |
Contributor
Hydration Benchmark Report (vs Baseline)✅ Top 5 Improvements (Best Speedups)
🔻 Flop 5 Regressions (Worst Slowdowns)
📋 Show all results
|
deleonio
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: