Skip to content

Disable accessible autocomplete overlay comments#8042

Merged
deleonio merged 1 commit intorelease/2from
feature/remove-non-accessible-autocomplete-overlay
Jul 16, 2025
Merged

Disable accessible autocomplete overlay comments#8042
deleonio merged 1 commit intorelease/2from
feature/remove-non-accessible-autocomplete-overlay

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented Jul 16, 2025

This pull request focuses on enhancing accessibility by disabling browser autocomplete popups across multiple components. The changes ensure a consistent user experience and prevent interference from browser-generated autocomplete suggestions. The key updates include modifications to the KolCombobox, KolForm, and KolSingleSelect components, along with corresponding snapshot updates.

Accessibility Improvements:

Combobox Component:

  • Added autoComplete="off" to the KolCombobox component to disable browser autocomplete popups.
  • Updated snapshots for KolCombobox tests to reflect the addition of autoComplete="off". [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Form Component:

  • Added autoComplete="off" to the KolForm component to prevent browser autocomplete popups, along with a comment explaining the change.

Single Select Component:

  • Added autoComplete="off" to the KolSingleSelect component to disable browser autocomplete popups.
  • Updated snapshots for KolSingleSelect tests to reflect the addition of autoComplete="off". [1] [2] [3] [4]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 16, 2025

@deleonio deleonio force-pushed the feature/remove-non-accessible-autocomplete-overlay branch from c8d6aa6 to 60e0eb8 Compare July 16, 2025 03:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 16, 2025

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-logo 27.5ms 31.6ms -13%
kol-quote 21.7ms 24.7ms -12.1%
kol-popover-button 83.7ms 89.2ms -6.2%
kol-image 18.9ms 20.1ms -6%
kol-modal 22.4ms 23.5ms -4.7%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-indented-text 27.4ms 21.4ms +28% 🔻
kol-drawer 27.1ms 21.4ms +26.6% 🔻
kol-avatar 26.8ms 23.2ms +15.5% 🔻
kol-link-group 24.8ms 22.3ms +11.2% 🔻
kol-tree 29.4ms 26.6ms +10.5% 🔻
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 28.1ms 29.1ms -3.4%
kol-accordion 160.3ms 158.2ms +1.3%
kol-alert 112.7ms 113.7ms -0.9%
kol-avatar 26.8ms 23.2ms +15.5% 🔻
kol-badge 74.2ms 75.1ms -1.2%
kol-breadcrumb 93.5ms 93.6ms -0.1%
kol-button 76.9ms 77.7ms -1%
kol-button-group 21.6ms 20.3ms +6.4%
kol-button-link 64.1ms 62.3ms +2.9%
kol-card 31.8ms 31.1ms +2.3%
kol-details 160.9ms 159.9ms +0.6%
kol-drawer 27.1ms 21.4ms +26.6% 🔻
kol-form 36.5ms 37.2ms -1.9%
kol-heading 25.7ms 26ms -1.2%
kol-icon 70.4ms 68.5ms +2.8%
kol-image 18.9ms 20.1ms -6%
kol-indented-text 27.4ms 21.4ms +28% 🔻
kol-input-checkbox 154.7ms 148.7ms +4%
kol-input-color 71.1ms 72.8ms -2.3%
kol-input-date 78.9ms 75.1ms +5.1%
kol-input-email 74.1ms 73.2ms +1.2%
kol-input-file 72.5ms 66.6ms +8.9%
kol-input-number 74.8ms 72.7ms +2.9%
kol-input-password 72.2ms 71.1ms +1.5%
kol-input-radio 51.3ms 52.4ms -2.1%
kol-input-text 76.3ms 74.8ms +2%
kol-link 63.7ms 66.2ms -3.8%
kol-link-button 73.6ms 72.9ms +1%
kol-link-group 24.8ms 22.3ms +11.2% 🔻
kol-logo 27.5ms 31.6ms -13%
kol-modal 22.4ms 23.5ms -4.7%
kol-nav 30.3ms 29.9ms +1.3%
kol-pagination 524ms 525.6ms -0.3%
kol-popover-button 83.7ms 89.2ms -6.2%
kol-progress 32.9ms 32ms +2.8%
kol-quote 21.7ms 24.7ms -12.1%
kol-select 89.6ms 89.6ms 0%
kol-skip-nav 21.5ms 20.4ms +5.4%
kol-spin 23.2ms 23.2ms 0%
kol-split-button 211.5ms 202.4ms +4.5%
kol-table-stateful 96.2ms 98ms -1.8%
kol-table-stateless 84.6ms 84.1ms +0.6%
kol-tabs 36.3ms 35.4ms +2.5%
kol-textarea 70.4ms 70.4ms +0%
kol-toolbar 33.7ms 34.9ms -3.4%
kol-tree 29.4ms 26.6ms +10.5% 🔻
kol-tree-item 80.4ms 82.5ms -2.5%
kol-version 158.4ms 161.3ms -1.8%

@deleonio deleonio marked this pull request as ready for review July 16, 2025 03:51
@deleonio deleonio requested a review from laske185 July 16, 2025 03:52
@deleonio deleonio force-pushed the feature/remove-non-accessible-autocomplete-overlay branch from 60e0eb8 to 3575581 Compare July 16, 2025 04:12
@deleonio deleonio merged commit 6a6e3c8 into release/2 Jul 16, 2025
9 checks passed
@deleonio deleonio deleted the feature/remove-non-accessible-autocomplete-overlay branch July 16, 2025 14:52
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SingleSelect zeigt nicht barrierefreies Browser-Autocomplete an

1 participant