Disable accessible autocomplete overlay comments

[deleonio]

This pull request introduces several updates to improve the handling of the autoComplete property across multiple input components in the codebase. The changes primarily focus on replacing the InputTypeOnOff type with a new AutoCompletePropType, streamlining validation logic, and ensuring consistent default values for the autoComplete property. Additionally, minor refactoring was performed to optimize imports and code organization.

Updates to autoComplete Property:

• Type Replacement: The InputTypeOnOff type was replaced with AutoCompletePropType across all relevant input components (input-color, input-date, input-email, input-number, input-password). This new type better encapsulates the expected values for autoComplete. [1] [2] [3] [4] [5] [6]

• Validation Logic: Validation methods for the autoComplete property were updated to use a centralized validateAutoComplete function. This improves code reuse and simplifies the validation process. [1] [2] [3] [4] [5] [6]

• Default Values: The autoComplete property now consistently defaults to 'off' across all input components to disable browser autocomplete behavior by default. [1] [2] [3] [4]

Code Refactoring:

• Import Optimization: Redundant imports were removed, and the order of imports was adjusted for better readability and organization. For example, imports related to nonce and functional components were reorganized in input-color, input-date, input-email, and input-number components. [1] [2] [3]

• Snapshot Updates: Snapshots for the kol-form component were updated to reflect the removal of the autoComplete="off" attribute from the <form> element, aligning with the changes in the renderFormElement method.

These changes collectively enhance the maintainability and consistency of the codebase while ensuring better handling of the autoComplete property across components.

[github-actions]

Netlify Draft Deployment
URL: https://6880c3fefb8f84fe76d18532--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/projects/kolibri-public-ui/deploys/6880c3fefb8f84fe76d18532

[github-actions]

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component	Current	Baseline	Δ%	Result
kol-table-stateless	345.7ms	437ms	-20.9%	✅
kol-input-radio	47.1ms	56.5ms	-16.6%	✅
kol-skip-nav	20.1ms	23.6ms	-14.8%	✅
kol-input-color	70.6ms	81.9ms	-13.8%	✅
kol-input-email	54.1ms	62.5ms	-13.4%	✅

🔻 Flop 5 Regressions (Worst Slowdowns)

Component	Current	Baseline	Δ%	Result
kol-drawer	40.6ms	25.6ms	+58.6%	🔻
kol-card	29.5ms	22.6ms	+30.5%	🔻
kol-tree-item	69.1ms	64ms	+8%	➖
kol-icon	69.6ms	65.1ms	+6.9%	➖
kol-pagination	442.3ms	423.8ms	+4.4%	➖

📋 Show all results

Component	Current	Baseline	Δ%	Result
kol-abbr	17.7ms	19.8ms	-10.6%	✅
kol-accordion	129.3ms	131ms	-1.3%	➖
kol-alert	109.3ms	105.9ms	+3.2%	➖
kol-avatar	26.7ms	26.9ms	-0.7%	➖
kol-badge	63.7ms	70.1ms	-9.1%	➖
kol-breadcrumb	93.4ms	97.6ms	-4.3%	➖
kol-button	58.8ms	63ms	-6.7%	➖
kol-button-link	50.7ms	50.7ms	0%	➖
kol-card	29.5ms	22.6ms	+30.5%	🔻
kol-details	129.3ms	134.9ms	-4.2%	➖
kol-drawer	40.6ms	25.6ms	+58.6%	🔻
kol-form	33.9ms	35.6ms	-4.8%	➖
kol-heading	20.6ms	21.5ms	-4.2%	➖
kol-icon	69.6ms	65.1ms	+6.9%	➖
kol-image	18.5ms	19.3ms	-4.1%	➖
kol-input-checkbox	138.4ms	141.3ms	-2.1%	➖
kol-input-color	70.6ms	81.9ms	-13.8%	✅
kol-input-date	66.5ms	70.3ms	-5.4%	➖
kol-input-email	54.1ms	62.5ms	-13.4%	✅
kol-input-file	92.2ms	93.7ms	-1.6%	➖
kol-input-number	51.9ms	56.1ms	-7.5%	➖
kol-input-password	53.4ms	51.6ms	+3.5%	➖
kol-input-radio	47.1ms	56.5ms	-16.6%	✅
kol-input-text	51.8ms	59.3ms	-12.6%	✅
kol-link	49.8ms	49.8ms	0%	➖
kol-link-button	58.4ms	56.5ms	+3.4%	➖
kol-modal	20.5ms	20.5ms	0%	➖
kol-nav	32.5ms	33.9ms	-4.1%	➖
kol-pagination	442.3ms	423.8ms	+4.4%	➖
kol-popover-button	69.4ms	71.3ms	-2.7%	➖
kol-progress	28.9ms	32.8ms	-11.9%	✅
kol-quote	18.5ms	19ms	-2.6%	➖
kol-select	117.2ms	117.1ms	+0.1%	➖
kol-skip-nav	20.1ms	23.6ms	-14.8%	✅
kol-spin	23.5ms	24.2ms	-2.9%	➖
kol-split-button	172.3ms	174.7ms	-1.4%	➖
kol-table-stateful	363.4ms	374.7ms	-3%	➖
kol-table-stateless	345.7ms	437ms	-20.9%	✅
kol-tabs	29.6ms	32.3ms	-8.4%	➖
kol-textarea	52.5ms	54.1ms	-3%	➖
kol-toolbar	34.4ms	36ms	-4.4%	➖
kol-tree	25.8ms	26.5ms	-2.6%	➖
kol-tree-item	69.1ms	64ms	+8%	➖
kol-version	148.2ms	154.8ms	-4.3%	➖

[Copilot]

Pull Request Overview

This pull request modernizes the autoComplete property handling across all input components by introducing a new centralized AutoCompletePropType and validateAutoComplete function. The changes replace the deprecated InputTypeOnOff type with a more flexible type that supports both standard 'on'/'off' values and custom autocomplete strings, while establishing 'off' as the consistent default value.

Key changes include:

• Introduction of a centralized autocomplete validation system with AutoCompletePropType and validateAutoComplete function
• Replacement of InputTypeOnOff with AutoCompletePropType across all input components (color, date, email, number, password, range, text)
• Removal of hardcoded autocomplete defaults from component state in favor of prop-level defaults

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/components/src/schema/props/auto-complete.ts	New centralized autocomplete validation and type definition
packages/components/src/schema/types/input/types.ts	Removal of deprecated InputTypeOnOff type
packages/components/src/components/*/shadow.tsx	Updated all input components to use new autocomplete type with 'off' default
packages/components/src/components/*/controller.ts	Refactored controllers to use centralized autocomplete validation
packages/components/src/components/form/shadow.tsx	Removed hardcoded autocomplete attribute from form element