Skip to content

Fix CLI tests#8054

Merged
deleonio merged 1 commit intofeature/einrichten-von-tests-fur-migrationstasksfrom
feature/fix-cli-test-error
Jul 17, 2025
Merged

Fix CLI tests#8054
deleonio merged 1 commit intofeature/einrichten-von-tests-fur-migrationstasksfrom
feature/fix-cli-test-error

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented Jul 17, 2025

This pull request updates the test suite for the kolibri-cli package by replacing import statements with require for dynamic imports, fixing type issues, and refining test logic. The changes improve compatibility with TypeScript and enhance test robustness.

Dynamic Import Adjustments:

  • Replaced import statements with require for modules like typed-bem and child_process in test files to align with dynamic import requirements. Additionally, added type assertions (e.g., (childProc as any)) to resolve type compatibility issues. ([[1]](https://github.com/public-ui/kolibri/pull/8054/files#diff-43c2c697e00052437a19b2faa0283bbf06768b62c65dd6ef6f525bfab54ead45L18-R18), [[2]](https://github.com/public-ui/kolibri/pull/8054/files#diff-43c2c697e00052437a19b2faa0283bbf06768b62c65dd6ef6f525bfab54ead45R55-R57), [[3]](https://github.com/public-ui/kolibri/pull/8054/files#diff-a4a58d9e078975eb0c6b61f8b44ccae2400875a0da46e356ae91280f83da0dc6L6-R17), [[4]](https://github.com/public-ui/kolibri/pull/8054/files#diff-58987e1ea84538c50872f46febb8b7ba89a73d168a9a35a7206518edbf012e30L7-R15), [[5]](https://github.com/public-ui/kolibri/pull/8054/files#diff-f76ea754f21f5e34a97c42b467a919c8d2eff5a47127cd7f6a3e353e2d5f0644R5-R24))

Test Logic Refinements:

  • Updated the JsonTask and TsConfigReconfigureTask tests to correctly pass nested object structures in their configurations. ([[1]](https://github.com/public-ui/kolibri/pull/8054/files#diff-5bc45b3656bc874217ec75bf3ca0c7bcb208781cc1d0093f80001e2dbaaf8824L14-R14), [[2]](https://github.com/public-ui/kolibri/pull/8054/files#diff-f1c5ffdd4c9403ddc0fdb7e62ff93b00c75a34ee6cd4c2e01d280bc3a38d48c2L14-R14))
  • Modified the RenameSlotNameTask test to clarify that only component files are processed, leaving HTML files unchanged. ([packages/tools/kolibri-cli/test/rename-slot.spec.tsL21-R22](https://github.com/public-ui/kolibri/pull/8054/files#diff-0a66b59d05a9a7aab7bcd6f74c91249a39656afc953a2fd20ee110fc8e630e9fL21-R22))

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-form 30.2ms 35.6ms -15.2%
kol-input-color 70.4ms 81.9ms -14%
kol-input-radio 49.3ms 56.5ms -12.7%
kol-nav 29.6ms 33.9ms -12.7%
kol-table-stateless 382.5ms 437ms -12.5%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-drawer 40.3ms 25.6ms +57.4% 🔻
kol-card 29ms 22.6ms +28.3% 🔻
kol-icon 76.8ms 65.1ms +18% 🔻
kol-quote 22.4ms 19ms +17.9% 🔻
kol-alert 113.9ms 105.9ms +7.6%
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 17.8ms 19.8ms -10.1%
kol-accordion 128.7ms 131ms -1.8%
kol-alert 113.9ms 105.9ms +7.6%
kol-avatar 25.6ms 26.9ms -4.8%
kol-badge 63.4ms 70.1ms -9.6%
kol-breadcrumb 96.9ms 97.6ms -0.7%
kol-button 60.5ms 63ms -4%
kol-button-link 51.6ms 50.7ms +1.8%
kol-card 29ms 22.6ms +28.3% 🔻
kol-details 132.8ms 134.9ms -1.6%
kol-drawer 40.3ms 25.6ms +57.4% 🔻
kol-form 30.2ms 35.6ms -15.2%
kol-heading 20.6ms 21.5ms -4.2%
kol-icon 76.8ms 65.1ms +18% 🔻
kol-image 19ms 19.3ms -1.6%
kol-input-checkbox 135.4ms 141.3ms -4.2%
kol-input-color 70.4ms 81.9ms -14%
kol-input-date 69.4ms 70.3ms -1.3%
kol-input-email 61.7ms 62.5ms -1.3%
kol-input-file 90.6ms 93.7ms -3.3%
kol-input-number 55.1ms 56.1ms -1.8%
kol-input-password 52ms 51.6ms +0.8%
kol-input-radio 49.3ms 56.5ms -12.7%
kol-input-text 55.9ms 59.3ms -5.7%
kol-link 49.6ms 49.8ms -0.4%
kol-link-button 59.9ms 56.5ms +6%
kol-modal 19.8ms 20.5ms -3.4%
kol-nav 29.6ms 33.9ms -12.7%
kol-pagination 454.7ms 423.8ms +7.3%
kol-popover-button 73.9ms 71.3ms +3.6%
kol-progress 30ms 32.8ms -8.5%
kol-quote 22.4ms 19ms +17.9% 🔻
kol-select 119.1ms 117.1ms +1.7%
kol-skip-nav 23ms 23.6ms -2.5%
kol-spin 23.4ms 24.2ms -3.3%
kol-split-button 164.9ms 174.7ms -5.6%
kol-table-stateful 356.2ms 374.7ms -4.9%
kol-table-stateless 382.5ms 437ms -12.5%
kol-tabs 30.3ms 32.3ms -6.2%
kol-textarea 52ms 54.1ms -3.9%
kol-toolbar 32.8ms 36ms -8.9%
kol-tree 28.3ms 26.5ms +6.8%
kol-tree-item 65.3ms 64ms +2%
kol-version 144.5ms 154.8ms -6.7%

@deleonio deleonio marked this pull request as ready for review July 17, 2025 09:40
@deleonio deleonio merged commit 681270b into feature/einrichten-von-tests-fur-migrationstasks Jul 17, 2025
8 checks passed
@deleonio deleonio deleted the feature/fix-cli-test-error branch July 17, 2025 09:41
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant