Skip to content

Fix broken tooltip layout with container layout issues#8062

Merged
laske185 merged 5 commits intorelease/2from
7987-fix-tooltip-v2
Jul 22, 2025
Merged

Fix broken tooltip layout with container layout issues#8062
laske185 merged 5 commits intorelease/2from
7987-fix-tooltip-v2

Conversation

@anicyne
Copy link
Copy Markdown
Contributor

@anicyne anicyne commented Jul 18, 2025

Refs: #7987

@anicyne anicyne linked an issue Jul 18, 2025 that may be closed by this pull request
Tootips fehlerhaft platziert bei der Verwendung von Container Queries #7987
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://687f9456344ef95ba9cd4d6d--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/projects/kolibri-public-ui/deploys/687f9456344ef95ba9cd4d6d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-logo 27.2ms 31.6ms -13.9% ✅
kol-abbr 25.1ms 29.1ms -13.7% ✅
kol-quote 21.5ms 24.7ms -13% ✅
kol-popover-button 78.8ms 89.2ms -11.7% ✅
kol-input-text 67.8ms 74.8ms -9.4% ➖

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-button-group 32.8ms 20.3ms +61.6% 🔻
kol-indented-text 28.2ms 21.4ms +31.8% 🔻
kol-drawer 25.7ms 21.4ms +20.1% 🔻
kol-link-group 26.7ms 22.3ms +19.7% 🔻
kol-avatar 26.3ms 23.2ms +13.4% 🔻
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 25.1ms 29.1ms -13.7% ✅
kol-accordion 154.5ms 158.2ms -2.3% ➖
kol-alert 113ms 113.7ms -0.6% ➖
kol-avatar 26.3ms 23.2ms +13.4% 🔻
kol-badge 72.3ms 75.1ms -3.7% ➖
kol-breadcrumb 94.5ms 93.6ms +1% ➖
kol-button 78.9ms 77.7ms +1.5% ➖
kol-button-group 32.8ms 20.3ms +61.6% 🔻
kol-button-link 63.1ms 62.3ms +1.3% ➖
kol-card 30.7ms 31.1ms -1.3% ➖
kol-details 155.2ms 159.9ms -2.9% ➖
kol-drawer 25.7ms 21.4ms +20.1% 🔻
kol-form 36.4ms 37.2ms -2.2% ➖
kol-heading 28.6ms 26ms +10% ➖
kol-icon 66.3ms 68.5ms -3.2% ➖
kol-image 19.1ms 20.1ms -5% ➖
kol-indented-text 28.2ms 21.4ms +31.8% 🔻
kol-input-checkbox 147.1ms 148.7ms -1.1% ➖
kol-input-color 72.2ms 72.8ms -0.8% ➖
kol-input-date 79.4ms 75.1ms +5.7% ➖
kol-input-email 67.4ms 73.2ms -7.9% ➖
kol-input-file 66.9ms 66.6ms +0.5% ➖
kol-input-number 74.1ms 72.7ms +1.9% ➖
kol-input-password 70.2ms 71.1ms -1.3% ➖
kol-input-radio 50.7ms 52.4ms -3.2% ➖
kol-input-text 67.8ms 74.8ms -9.4% ➖
kol-link 63.1ms 66.2ms -4.7% ➖
kol-link-button 73.1ms 72.9ms +0.3% ➖
kol-link-group 26.7ms 22.3ms +19.7% 🔻
kol-logo 27.2ms 31.6ms -13.9% ✅
kol-modal 21.4ms 23.5ms -8.9% ➖
kol-nav 30ms 29.9ms +0.3% ➖
kol-pagination 577.4ms 525.6ms +9.9% ➖
kol-popover-button 78.8ms 89.2ms -11.7% ✅
kol-progress 33.9ms 32ms +5.9% ➖
kol-quote 21.5ms 24.7ms -13% ✅
kol-select 86.4ms 89.6ms -3.6% ➖
kol-skip-nav 20ms 20.4ms -2% ➖
kol-spin 23.3ms 23.2ms +0.4% ➖
kol-split-button 197.6ms 202.4ms -2.4% ➖
kol-table-stateful 93.8ms 98ms -4.3% ➖
kol-table-stateless 82.2ms 84.1ms -2.3% ➖
kol-tabs 37ms 35.4ms +4.5% ➖
kol-textarea 67.2ms 70.4ms -4.5% ➖
kol-toolbar 34.2ms 34.9ms -2% ➖
kol-tree 26.7ms 26.6ms +0.4% ➖
kol-tree-item 82.3ms 82.5ms -0.2% ➖
kol-version 160.1ms 161.3ms -0.7% ➖

deleonio
deleonio requested changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@deleonio deleonio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siehe #7987 (comment)

@anicyne anicyne marked this pull request as draft July 18, 2025 14:32
sdvg added 3 commits July 22, 2025 15:11
@sdvg
Merge branch 'release/2' of github.com:public-ui/kolibri into 7987-fi…
e4bf6bb 
…x-tooltip-v2

* 'release/2' of github.com:public-ui/kolibri:
  feat: add GitHub Actions workflow to handle PR labels
  chore: disable benchmark workflows
  feat(table-stateless): update sorting accessibility text and localization
  chore: release 2.2.13-rc.2
  Fix: selecting typed value on blur in single-select
  fix: disable browser autocomplete for combobox and single-select inputs
  Fix: Clear button causes crash in Singleselect
@sdvg
Tooltip: Add layout containment to prevent container query positionin…
54a079f 
…g issues.

The `contain: layout` property isolates tooltip positioning calculations rom parent container query contexts, ensuring tooltips position correctly relative to the viewport.

Refs: #7987
@sdvg
Sample: Simplify, move to scenarios and remove dependency on global s…
695c602 
…tyles

Refs: #7987
@sdvg sdvg marked this pull request as ready for review July 22, 2025 13:41
@laske185 laske185 merged commit 941fe2a into release/2 Jul 22, 2025
8 checks passed
@laske185 laske185 deleted the 7987-fix-tooltip-v2 branch July 22, 2025 14:03
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deleonio deleonio deleonio requested changes

@laske185 laske185 laske185 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tootips fehlerhaft platziert bei der Verwendung von Container Queries

4 participants

@anicyne @deleonio @laske185 @sdvg
⚡