Skip to content

Rename rem() to to-rem()#8075

Merged
laske185 merged 1 commit intorelease/2from
7510-rename-rem-function
Jul 22, 2025
Merged

Rename rem() to to-rem()#8075
laske185 merged 1 commit intorelease/2from
7510-rename-rem-function

Conversation

@anicyne
Copy link
Copy Markdown
Contributor

@anicyne anicyne commented Jul 18, 2025

No description provided.

@anicyne anicyne linked an issue Jul 18, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-abbr 24.8ms 29.1ms -14.8%
kol-modal 20.4ms 23.5ms -13.2%
kol-popover-button 79.8ms 89.2ms -10.5%
kol-image 18.2ms 20.1ms -9.5%
kol-link 61.3ms 66.2ms -7.4%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-indented-text 27.6ms 21.4ms +29% 🔻
kol-drawer 26.8ms 21.4ms +25.2% 🔻
kol-heading 30.4ms 26ms +16.9% 🔻
kol-button-link 72.5ms 62.3ms +16.4% 🔻
kol-avatar 26.5ms 23.2ms +14.2% 🔻
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 24.8ms 29.1ms -14.8%
kol-accordion 154ms 158.2ms -2.7%
kol-alert 111.2ms 113.7ms -2.2%
kol-avatar 26.5ms 23.2ms +14.2% 🔻
kol-badge 76.5ms 75.1ms +1.9%
kol-breadcrumb 91.5ms 93.6ms -2.2%
kol-button 76.5ms 77.7ms -1.5%
kol-button-group 20.5ms 20.3ms +1%
kol-button-link 72.5ms 62.3ms +16.4% 🔻
kol-card 30.8ms 31.1ms -1%
kol-details 155.4ms 159.9ms -2.8%
kol-drawer 26.8ms 21.4ms +25.2% 🔻
kol-form 38.8ms 37.2ms +4.3%
kol-heading 30.4ms 26ms +16.9% 🔻
kol-icon 64.8ms 68.5ms -5.4%
kol-image 18.2ms 20.1ms -9.5%
kol-indented-text 27.6ms 21.4ms +29% 🔻
kol-input-checkbox 148.8ms 148.7ms +0.1%
kol-input-color 68.1ms 72.8ms -6.5%
kol-input-date 75.7ms 75.1ms +0.8%
kol-input-email 75.1ms 73.2ms +2.6%
kol-input-file 70.7ms 66.6ms +6.2%
kol-input-number 74.8ms 72.7ms +2.9%
kol-input-password 71.2ms 71.1ms +0.1%
kol-input-radio 52.1ms 52.4ms -0.6%
kol-input-text 71.2ms 74.8ms -4.8%
kol-link 61.3ms 66.2ms -7.4%
kol-link-button 72.2ms 72.9ms -1%
kol-link-group 24.8ms 22.3ms +11.2% 🔻
kol-logo 31ms 31.6ms -1.9%
kol-modal 20.4ms 23.5ms -13.2%
kol-nav 31.9ms 29.9ms +6.7%
kol-pagination 547ms 525.6ms +4.1%
kol-popover-button 79.8ms 89.2ms -10.5%
kol-progress 33.5ms 32ms +4.7%
kol-quote 24.3ms 24.7ms -1.6%
kol-select 84.9ms 89.6ms -5.2%
kol-skip-nav 21.4ms 20.4ms +4.9%
kol-spin 25.3ms 23.2ms +9.1%
kol-split-button 199.1ms 202.4ms -1.6%
kol-table-stateful 91.8ms 98ms -6.3%
kol-table-stateless 82.4ms 84.1ms -2%
kol-tabs 36.3ms 35.4ms +2.5%
kol-textarea 69.5ms 70.4ms -1.3%
kol-toolbar 34ms 34.9ms -2.6%
kol-tree 26.2ms 26.6ms -1.5%
kol-tree-item 84.3ms 82.5ms +2.2%
kol-version 161.8ms 161.3ms +0.3%

@anicyne anicyne force-pushed the 7510-rename-rem-function branch from af5ff86 to 3dc89b0 Compare July 18, 2025 14:35
@deleonio deleonio changed the title Rename rem() to rem() Rename rem() to to-rem() Jul 22, 2025
@deleonio deleonio requested a review from Copilot July 22, 2025 13:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request renames the rem() function to to-rem() across the entire codebase to improve naming clarity and consistency. The change affects both the function definition and all its usages throughout the Sass files.

  • Updates function name from rem() to to-rem() for better semantic clarity
  • Updates all import statements to reference the new function file path
  • Replaces all function calls from rem() to to-rem() throughout the codebase

Reviewed Changes

Copilot reviewed 135 out of 135 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/themes/*/src/functions/to-rem.scss Renamed function definition from rem() to to-rem()
packages/themes//src/mixins/.scss Updated imports and function calls to use to-rem()
packages/themes//src/components/.scss Updated imports and function calls to use to-rem()
packages/themes/*/src/global.scss Updated imports and function calls to use to-rem()
packages/components/src/components/**/*.scss Updated imports and function calls to use to-rem()
packages/samples/react/src/**/*.scss Updated imports and function calls to use to-rem()

@laske185 laske185 merged commit 4851ae3 into release/2 Jul 22, 2025
9 checks passed
@laske185 laske185 deleted the 7510-rename-rem-function branch July 22, 2025 13:44
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename rem method

3 participants