Skip to content

Fix CLI build issues with ESM modules#8076

Closed
deleonio wants to merge 1 commit intofeature/update-migrations-tool-auf-3.0.1from
feature/cli-tests-fehlerbeheben
Closed

Fix CLI build issues with ESM modules#8076
deleonio wants to merge 1 commit intofeature/update-migrations-tool-auf-3.0.1from
feature/cli-tests-fehlerbeheben

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented Jul 18, 2025

Summary

  • use ESM module settings for the kolibri-cli
  • require BEM constants via require with lint/TS hints
  • add custom type declaration and tsconfig updates

Testing

  • pnpm test

https://chatgpt.com/codex/tasks/task_e_687a4f847a7c832ba5a5c64b1e812854

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio marked this pull request as draft July 18, 2025 14:48
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-input-radio 49.4ms 56.5ms -12.6%
kol-tabs 28.6ms 32.3ms -11.5%
kol-nav 30.1ms 33.9ms -11.2%
kol-skip-nav 21.6ms 23.6ms -8.5%
kol-abbr 18.2ms 19.8ms -8.1%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-drawer 46.2ms 25.6ms +80.5% 🔻
kol-card 30.4ms 22.6ms +34.5% 🔻
kol-button-link 62ms 50.7ms +22.3% 🔻
kol-quote 22.5ms 19ms +18.4% 🔻
kol-spin 27.4ms 24.2ms +13.2% 🔻
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 18.2ms 19.8ms -8.1%
kol-accordion 135.6ms 131ms +3.5%
kol-alert 112.2ms 105.9ms +5.9%
kol-avatar 26.9ms 26.9ms 0%
kol-badge 69.2ms 70.1ms -1.3%
kol-breadcrumb 97.3ms 97.6ms -0.3%
kol-button 64.5ms 63ms +2.4%
kol-button-link 62ms 50.7ms +22.3% 🔻
kol-card 30.4ms 22.6ms +34.5% 🔻
kol-details 134.2ms 134.9ms -0.5%
kol-drawer 46.2ms 25.6ms +80.5% 🔻
kol-form 35.9ms 35.6ms +0.8%
kol-heading 22.2ms 21.5ms +3.3%
kol-icon 68.4ms 65.1ms +5.1%
kol-image 19.9ms 19.3ms +3.1%
kol-input-checkbox 141.9ms 141.3ms +0.4%
kol-input-color 82ms 81.9ms +0.1%
kol-input-date 73.1ms 70.3ms +4%
kol-input-email 58.1ms 62.5ms -7%
kol-input-file 102.8ms 93.7ms +9.7%
kol-input-number 62.7ms 56.1ms +11.8% 🔻
kol-input-password 52.2ms 51.6ms +1.2%
kol-input-radio 49.4ms 56.5ms -12.6%
kol-input-text 62.1ms 59.3ms +4.7%
kol-link 52.8ms 49.8ms +6%
kol-link-button 62.1ms 56.5ms +9.9%
kol-modal 21ms 20.5ms +2.4%
kol-nav 30.1ms 33.9ms -11.2%
kol-pagination 434.1ms 423.8ms +2.4%
kol-popover-button 70.9ms 71.3ms -0.6%
kol-progress 30.3ms 32.8ms -7.6%
kol-quote 22.5ms 19ms +18.4% 🔻
kol-select 115.2ms 117.1ms -1.6%
kol-skip-nav 21.6ms 23.6ms -8.5%
kol-spin 27.4ms 24.2ms +13.2% 🔻
kol-split-button 170.2ms 174.7ms -2.6%
kol-table-stateful 364.9ms 374.7ms -2.6%
kol-table-stateless 459ms 437ms +5%
kol-tabs 28.6ms 32.3ms -11.5%
kol-textarea 53.1ms 54.1ms -1.8%
kol-toolbar 33.9ms 36ms -5.8%
kol-tree 29ms 26.5ms +9.4%
kol-tree-item 66.2ms 64ms +3.4%
kol-version 148.3ms 154.8ms -4.2%

@deleonio deleonio closed this Jul 19, 2025
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 19, 2025
@deleonio deleonio deleted the feature/cli-tests-fehlerbeheben branch September 22, 2025 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant