Merged
Conversation
Contributor
|
Netlify Draft Deployment |
Contributor
Hydration Benchmark Report (vs Baseline)✅ Top 5 Improvements (Best Speedups)
🔻 Flop 5 Regressions (Worst Slowdowns)
📋 Show all results
|
…rrel-ansatz Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes barrel wrapper files from the component architecture to align with updated coding conventions that discourage barrel files in favor of direct imports. The changes systematically replace barrel file imports with direct module imports across all form components and input components.
Key Changes:
- Added coding guideline discouraging barrel files (
index.tsre-export modules) - Removed barrel files from all functional component wrapper directories
- Updated import paths in 14 component shadow files to use direct imports instead of barrel imports
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AGENTS.md | Added guideline discouraging barrel files and recommending direct imports |
| packages/components/src/functional-component-wrappers/*/index.ts | Removed barrel files from 8 wrapper directories |
| packages/components/src/components/*/shadow.tsx | Updated 14 component files to use direct imports instead of barrel imports |
deleonio
deleted the
0rn7b1-feature/uberprufe-anwendung-von-barrel-ansatz
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve module imports and enforce coding conventions. The most significant updates involve replacing barrel files with direct imports and modifying import paths across multiple components. Additionally, coding guidelines were updated to discourage the creation of barrel files.
Coding Conventions:
AGENTS.mdto include a guideline discouraging the creation of barrel files (e.g.,index.ts) and recommending direct module imports instead.Import Path Updates:
packages/components/src/components/combobox/shadow.tsx,input-checkbox/shadow.tsx,input-color/shadow.tsx,input-date/shadow.tsx,input-email/shadow.tsx,input-file/shadow.tsx,input-number/shadow.tsx,input-password/shadow.tsx,input-radio/shadow.tsx,input-range/shadow.tsx,input-text/shadow.tsx,select/shadow.tsx,single-select/shadow.tsx, andtextarea/shadow.tsx. For example,KolFormFieldStateWrapperFcnow imports directly fromFormFieldStateWrapper/FormFieldStateWrapper. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Barrel File Removal:
index.ts) from the following directories:CheckboxStateWrapper,FieldControlStateWrapper,FormFieldStateWrapper,InputContainerStateWrapper, andInputStateWrapper. This aligns with the updated coding conventions. [1] [2] [3] [4] [5]