Skip to content

Rename rem() to to-rem()#8092

Merged
laske185 merged 2 commits intodevelopfrom
7510-rename-rem-function-v3
Jul 22, 2025
Merged

Rename rem() to to-rem()#8092
laske185 merged 2 commits intodevelopfrom
7510-rename-rem-function-v3

Conversation

@anicyne
Copy link
Copy Markdown
Contributor

@anicyne anicyne commented Jul 21, 2025

Refs: #7510

@anicyne anicyne linked an issue Jul 21, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-table-stateless 363.4ms 437ms -16.8%
kol-avatar 22.5ms 26.9ms -16.4%
kol-form 30.8ms 35.6ms -13.5%
kol-spin 21ms 24.2ms -13.2%
kol-abbr 17.2ms 19.8ms -13.1%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-drawer 41.3ms 25.6ms +61.3% 🔻
kol-card 27.4ms 22.6ms +21.2% 🔻
kol-input-number 61.8ms 56.1ms +10.2% 🔻
kol-alert 114.3ms 105.9ms +7.9%
kol-modal 22.1ms 20.5ms +7.8%
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 17.2ms 19.8ms -13.1%
kol-accordion 129.6ms 131ms -1.1%
kol-alert 114.3ms 105.9ms +7.9%
kol-avatar 22.5ms 26.9ms -16.4%
kol-badge 65.5ms 70.1ms -6.6%
kol-breadcrumb 94.6ms 97.6ms -3.1%
kol-button 59.6ms 63ms -5.4%
kol-button-link 50.2ms 50.7ms -1%
kol-card 27.4ms 22.6ms +21.2% 🔻
kol-details 128.4ms 134.9ms -4.8%
kol-drawer 41.3ms 25.6ms +61.3% 🔻
kol-form 30.8ms 35.6ms -13.5%
kol-heading 21.9ms 21.5ms +1.9%
kol-icon 64.2ms 65.1ms -1.4%
kol-image 18.1ms 19.3ms -6.2%
kol-input-checkbox 137.9ms 141.3ms -2.4%
kol-input-color 71.6ms 81.9ms -12.6%
kol-input-date 68.5ms 70.3ms -2.6%
kol-input-email 56.2ms 62.5ms -10.1%
kol-input-file 91.7ms 93.7ms -2.1%
kol-input-number 61.8ms 56.1ms +10.2% 🔻
kol-input-password 51.4ms 51.6ms -0.4%
kol-input-radio 51.9ms 56.5ms -8.1%
kol-input-text 62.3ms 59.3ms +5.1%
kol-link 50.5ms 49.8ms +1.4%
kol-link-button 59.9ms 56.5ms +6%
kol-modal 22.1ms 20.5ms +7.8%
kol-nav 29.8ms 33.9ms -12.1%
kol-pagination 442.8ms 423.8ms +4.5%
kol-popover-button 68.2ms 71.3ms -4.3%
kol-progress 31.3ms 32.8ms -4.6%
kol-quote 19.5ms 19ms +2.6%
kol-select 116.7ms 117.1ms -0.3%
kol-skip-nav 21.4ms 23.6ms -9.3%
kol-spin 21ms 24.2ms -13.2%
kol-split-button 167.2ms 174.7ms -4.3%
kol-table-stateful 391.6ms 374.7ms +4.5%
kol-table-stateless 363.4ms 437ms -16.8%
kol-tabs 29.8ms 32.3ms -7.7%
kol-textarea 49.9ms 54.1ms -7.8%
kol-toolbar 32.7ms 36ms -9.2%
kol-tree 26.7ms 26.5ms +0.8%
kol-tree-item 64.4ms 64ms +0.6%
kol-version 153ms 154.8ms -1.2%

@sdvg sdvg changed the title Rename rem() to rem() Rename rem() to to-rem() Jul 22, 2025
@deleonio deleonio changed the title Rename rem() to to-rem() Rename rem() to to-rem() Jul 22, 2025
@deleonio deleonio requested a review from Copilot July 22, 2025 13:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the rem() SCSS function to to-rem() across all theme and component files to improve naming clarity and consistency. The function implementation remains unchanged - it still converts pixel values to rem units using CSS calc() with a configurable root font size.

Key Changes:

  • Renamed function from rem() to to-rem() in all SCSS mixins and theme files
  • Updated all function calls throughout the codebase to use the new name
  • Updated documentation to reflect the new function name

Reviewed Changes

Copilot reviewed 162 out of 162 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/themes/ecl/src/mixins/to-rem.scss Renamed function definition from rem() to to-rem()
packages/themes/default/src/mixins/to-rem.scss Renamed function definition from rem() to to-rem()
packages/components/src/components/@shared/_mixins.scss Renamed function definition from rem() to to-rem()
Multiple theme and component files Updated all function calls from rem() to to-rem()
README files Updated documentation to reflect new function name
Comments suppressed due to low confidence (2)

@laske185 laske185 merged commit 9c33f00 into develop Jul 22, 2025
10 checks passed
@laske185 laske185 deleted the 7510-rename-rem-function-v3 branch July 22, 2025 13:42
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename rem method

3 participants