Conversation
Closed
Contributor
|
Netlify Draft Deployment |
Contributor
Hydration Benchmark Report (vs Baseline)✅ Top 5 Improvements (Best Speedups)
🔻 Flop 5 Regressions (Worst Slowdowns)
📋 Show all results
|
laske185
approved these changes
Jul 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the rem() SCSS function to to-rem() across all theme and component files to improve naming clarity and consistency. The function implementation remains unchanged - it still converts pixel values to rem units using CSS calc() with a configurable root font size.
Key Changes:
- Renamed function from
rem()toto-rem()in all SCSS mixins and theme files - Updated all function calls throughout the codebase to use the new name
- Updated documentation to reflect the new function name
Reviewed Changes
Copilot reviewed 162 out of 162 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/themes/ecl/src/mixins/to-rem.scss | Renamed function definition from rem() to to-rem() |
| packages/themes/default/src/mixins/to-rem.scss | Renamed function definition from rem() to to-rem() |
| packages/components/src/components/@shared/_mixins.scss | Renamed function definition from rem() to to-rem() |
| Multiple theme and component files | Updated all function calls from rem() to to-rem() |
| README files | Updated documentation to reflect new function name |
Comments suppressed due to low confidence (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #7510