Skip to content

feat(input-range): default range values#8093

Merged
laske185 merged 4 commits intodevelopfrom
feature/setze-standardwerte-von-inputrange
Jul 22, 2025
Merged

feat(input-range): default range values#8093
laske185 merged 4 commits intodevelopfrom
feature/setze-standardwerte-von-inputrange

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

@deleonio deleonio commented Jul 21, 2025

This pull request introduces default values for the _max and _min properties in the KolInputRange class within the input-range component. These changes ensure that the component has predefined bounds when no values are explicitly provided.

Default value additions:

@deleonio deleonio linked an issue Jul 21, 2025 that may be closed by this pull request
@deleonio deleonio requested a review from Copilot July 21, 2025 14:04

This comment was marked as outdated.

@deleonio deleonio marked this pull request as draft July 21, 2025 14:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025

Hydration Benchmark Report (vs Baseline)

✅ Top 5 Improvements (Best Speedups)

Component Current Baseline Δ% Result
kol-avatar 23.5ms 26.9ms -12.6%
kol-form 32ms 35.6ms -10.1%
kol-skip-nav 21.3ms 23.6ms -9.7%
kol-abbr 18.2ms 19.8ms -8.1%
kol-input-radio 52ms 56.5ms -8%

🔻 Flop 5 Regressions (Worst Slowdowns)

Component Current Baseline Δ% Result
kol-drawer 43.1ms 25.6ms +68.4% 🔻
kol-card 30.1ms 22.6ms +33.2% 🔻
kol-quote 23ms 19ms +21.1% 🔻
kol-link 58.6ms 49.8ms +17.7% 🔻
kol-input-password 59.5ms 51.6ms +15.3% 🔻
📋 Show all results
Component Current Baseline Δ% Result
kol-abbr 18.2ms 19.8ms -8.1%
kol-accordion 136.3ms 131ms +4%
kol-alert 114ms 105.9ms +7.6%
kol-avatar 23.5ms 26.9ms -12.6%
kol-badge 64.9ms 70.1ms -7.4%
kol-breadcrumb 98.9ms 97.6ms +1.3%
kol-button 66.8ms 63ms +6%
kol-button-link 54.4ms 50.7ms +7.3%
kol-card 30.1ms 22.6ms +33.2% 🔻
kol-details 132.1ms 134.9ms -2.1%
kol-drawer 43.1ms 25.6ms +68.4% 🔻
kol-form 32ms 35.6ms -10.1%
kol-heading 21.9ms 21.5ms +1.9%
kol-icon 67.5ms 65.1ms +3.7%
kol-image 19.3ms 19.3ms 0%
kol-input-checkbox 138.9ms 141.3ms -1.7%
kol-input-color 84.5ms 81.9ms +3.2%
kol-input-date 68.9ms 70.3ms -2%
kol-input-email 62.8ms 62.5ms +0.5%
kol-input-file 95ms 93.7ms +1.4%
kol-input-number 64.5ms 56.1ms +15% 🔻
kol-input-password 59.5ms 51.6ms +15.3% 🔻
kol-input-radio 52ms 56.5ms -8%
kol-input-text 60.5ms 59.3ms +2%
kol-link 58.6ms 49.8ms +17.7% 🔻
kol-link-button 57.3ms 56.5ms +1.4%
kol-modal 20.3ms 20.5ms -1%
kol-nav 36.2ms 33.9ms +6.8%
kol-pagination 448.5ms 423.8ms +5.8%
kol-popover-button 71.9ms 71.3ms +0.8%
kol-progress 35.3ms 32.8ms +7.6%
kol-quote 23ms 19ms +21.1% 🔻
kol-select 117ms 117.1ms -0.1%
kol-skip-nav 21.3ms 23.6ms -9.7%
kol-spin 25.9ms 24.2ms +7%
kol-split-button 173.8ms 174.7ms -0.5%
kol-table-stateful 370.8ms 374.7ms -1%
kol-table-stateless 431.4ms 437ms -1.3%
kol-tabs 30.9ms 32.3ms -4.3%
kol-textarea 53.4ms 54.1ms -1.3%
kol-toolbar 33.3ms 36ms -7.5%
kol-tree 28.2ms 26.5ms +6.4%
kol-tree-item 62.9ms 64ms -1.7%
kol-version 151.8ms 154.8ms -1.9%

@deleonio deleonio marked this pull request as ready for review July 21, 2025 23:32
@deleonio deleonio requested review from Copilot and laske185 July 21, 2025 23:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds default values to the _max and _min properties of the KolInputRange component to establish sensible boundaries when no explicit values are provided by the consumer.

  • Sets default maximum value to 100 for range inputs
  • Sets default minimum value to 0 for range inputs

Comment thread packages/components/src/components/input-range/shadow.tsx
Comment thread packages/components/src/components/input-range/shadow.tsx
@laske185 laske185 merged commit 2608788 into develop Jul 22, 2025
9 checks passed
@laske185 laske185 deleted the feature/setze-standardwerte-von-inputrange branch July 22, 2025 14:01
@publicuibot publicuibot bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardwerte für _min und _max beim InputRange

3 participants