feat(input-range): default range values#8093
Merged
Conversation
Contributor
|
Netlify Draft Deployment |
Contributor
Hydration Benchmark Report (vs Baseline)✅ Top 5 Improvements (Best Speedups)
🔻 Flop 5 Regressions (Worst Slowdowns)
📋 Show all results
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds default values to the _max and _min properties of the KolInputRange component to establish sensible boundaries when no explicit values are provided by the consumer.
- Sets default maximum value to 100 for range inputs
- Sets default minimum value to 0 for range inputs
laske185
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces default values for the
_maxand_minproperties in theKolInputRangeclass within theinput-rangecomponent. These changes ensure that the component has predefined bounds when no values are explicitly provided.Default value additions:
packages/components/src/components/input-range/shadow.tsx: Added default values for_max(set to100) and_min(set to0) properties in theKolInputRangeclass to establish default input range boundaries.