feat(input-range): default range values#8098
Merged
Conversation
Contributor
|
Netlify Draft Deployment |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds default values to the _max and _min properties of the KolInputRange component to ensure consistent behavior when these range boundaries are not explicitly specified by consumers.
- Sets default maximum value to 100 for the
_maxproperty - Sets default minimum value to 0 for the
_minproperty
laske185
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
KolInputRangeclass inshadow.tsxto set default values for the_maxand_minproperties, ensuring consistent behavior when these properties are not explicitly defined.packages/components/src/components/input-range/shadow.tsx: Added default values of100for_maxand0for_minproperties in theKolInputRangeclass.