Skip to content

fix: render tooltips only when labels are hidden#8564

Merged
deleonio merged 1 commit intodevelopfrom
feature/adjust-kol-tooltip-rendering-logic
Sep 30, 2025
Merged

fix: render tooltips only when labels are hidden#8564
deleonio merged 1 commit intodevelopfrom
feature/adjust-kol-tooltip-rendering-logic

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

Summary

  • render kol-tooltip on buttons and links only when their labels are hidden to avoid redundant DOM
  • guard the shared form field tooltip functional component behind a hideLabel check and adjust its tests and snapshots
  • update button, link, and form field tooltip snapshots to match the new conditional rendering

Testing

  • pnpm --filter @public-ui/components test:unit

https://chatgpt.com/codex/tasks/task_e_68da1fd50d90832bb746fa50c6add9c2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 29, 2025

@deleonio deleonio force-pushed the feature/adjust-kol-tooltip-rendering-logic branch from 8937eaf to b6b40ff Compare September 29, 2025 23:54
@deleonio deleonio force-pushed the feature/adjust-kol-tooltip-rendering-logic branch from b6b40ff to a92d98e Compare September 29, 2025 23:54
@deleonio deleonio merged commit 1b2b286 into develop Sep 30, 2025
10 checks passed
@deleonio deleonio deleted the feature/adjust-kol-tooltip-rendering-logic branch September 30, 2025 00:08
@publicuibot publicuibot bot locked and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant