Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| {hasAriaDescription && ( | ||
| <span class="visually-hidden" id={this.internalDescriptionById}> | ||
| <span hidden id={this.internalDescriptionById}> | ||
| {this.state._ariaDescription} |
There was a problem hiding this comment.
[P1] Preserve aria-describedby content for screen readers
The span that contains _ariaDescription was changed from class="visually-hidden" to hidden. Because the button’s aria-describedby points at this element, setting hidden removes it from the accessibility tree and screen readers stop announcing the description whenever _ariaDescription is used. The previous visually-hidden class kept the text off-screen but still exposed to assistive tech, which is required for aria-describedby to work.
Useful? React with 👍 / 👎.
|
Netlify Draft Deployment |
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68db17bc1f94832bb36e62d69202f741