Skip to content

fix: replace single-select clear icon with KolButtonWc#8729

Merged
laske185 merged 3 commits intorelease/3from
feature/update-multi-select-delete-to-kolbuttonwc
Nov 18, 2025
Merged

fix: replace single-select clear icon with KolButtonWc#8729
laske185 merged 3 commits intorelease/3from
feature/update-multi-select-delete-to-kolbuttonwc

Conversation

@deleonio
Copy link
Copy Markdown
Contributor

Summary

  • replace the single-select clear icon with KolButtonWc so the control is exposed as a proper button
  • adjust the component styles to style the nested button element instead of the host

Testing

  • not run (not requested)

https://chatgpt.com/codex/tasks/task_e_68fb160fcbbc832badd23f4808a8a460

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2025

🚀 MCP preview deployed to Vercel: https://kolibri-f601b6q3z-public-ui-kolibri-mcp.vercel.app

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2025

@deleonio deleonio force-pushed the feature/update-multi-select-delete-to-kolbuttonwc branch from d5d3edb to 5988d96 Compare October 25, 2025 06:06
@deleonio deleonio marked this pull request as draft October 27, 2025 08:05
@deleonio deleonio force-pushed the feature/update-multi-select-delete-to-kolbuttonwc branch 3 times, most recently from 358a06c to ea8362f Compare October 30, 2025 05:49
@deleonio deleonio moved this to 🔍 Review in KoliBri Board Oct 30, 2025
@deleonio deleonio marked this pull request as ready for review October 30, 2025 05:49
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/components/src/components/combobox/shadow.tsx
@deleonio deleonio self-assigned this Oct 30, 2025
@deleonio deleonio moved this from 🔍 Review to 🏗 In progress in KoliBri Board Nov 14, 2025
@deleonio deleonio force-pushed the feature/update-multi-select-delete-to-kolbuttonwc branch from 3e8c3df to 859b21b Compare November 18, 2025 02:18
@deleonio deleonio moved this from 🏗 In progress to 🔍 Review in KoliBri Board Nov 18, 2025
@deleonio deleonio requested a review from laske185 November 18, 2025 02:18
@deleonio deleonio force-pushed the feature/update-multi-select-delete-to-kolbuttonwc branch from fb8f6c3 to 3b57962 Compare November 18, 2025 02:43
@deleonio deleonio force-pushed the feature/update-multi-select-delete-to-kolbuttonwc branch from 6a15aac to 1904d91 Compare November 18, 2025 03:02
@laske185 laske185 merged commit 41339a9 into release/3 Nov 18, 2025
9 checks passed
@laske185 laske185 deleted the feature/update-multi-select-delete-to-kolbuttonwc branch November 18, 2025 14:22
@publicuibot publicuibot bot locked and limited conversation to collaborators Nov 18, 2025
@laske185 laske185 moved this from 🔍 Review to ✅ Done in KoliBri Board Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants