fix: button onclick doppeltes abschicken

[BF150]

was so ein kleines stopPropagation ausmacht

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request fixes a bug that caused buttons to submit forms twice. It also updates the React sample button components to use the correct event handling property.

Highlights

• Bug Fix: Addresses an issue where buttons were being submitted twice due to event propagation.
• Event Handling: Implements stopPropagation() to prevent unintended form submissions.
• Component Update: Updates button components to use onClick instead of _on for event handling in the React samples.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/components/src/components/button/component.tsx
  • Added event.stopPropagation() to the onClick handler to prevent double submissions.
• packages/samples/react/src/components/button/basic.tsx
  • Replaced _on with onClick for event handling in the primary, secondary, and tertiary button variants.

Activity

• BF150 authored the pull request with the title 'fix: button onclick doppeltes abschicken' and the description 'was so ein kleines stopPropagation ausmacht'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

🚀 MCP preview deployed to Vercel: https://kolibri-5eum4xhz7-public-ui-kolibri-mcp.vercel.app

[gemini-code-assist]

Code Review

Der Pull Request behebt das Problem der doppelten Übermittlung von Button-Klicks durch das Hinzufügen von event.stopPropagation() im onClick-Handler der KolButtonWc-Komponente. Dies ist eine effektive Lösung für das beschriebene Problem. Es sollte jedoch sorgfältig geprüft werden, ob stopPropagation() in allen Szenarien die gewünschte Wirkung hat, insbesondere im Hinblick auf potenzielle Nebenwirkungen bei der Event-Propagation zu übergeordneten Elementen oder bei Buttons vom Typ submit oder reset. Eine gezieltere Lösung zur Vermeidung von Mehrfachübermittlungen könnte in Betracht gezogen werden.

[github-actions]

Netlify Draft Deployment
URL: https://69b184bcea4add2ff1138be2--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/projects/kolibri-public-ui/deploys/69b184bcea4add2ff1138be2