Skip to content

fix: details component - less specific styles#9868

Merged
deleonio merged 5 commits intodevelopfrom
fix/9867-details-component-less-specific-styles
Mar 26, 2026
Merged

fix: details component - less specific styles#9868
deleonio merged 5 commits intodevelopfrom
fix/9867-details-component-less-specific-styles

Conversation

@BF150
Copy link
Copy Markdown
Contributor

@BF150 BF150 commented Mar 25, 2026

No description provided.

@BF150 BF150 self-assigned this Mar 25, 2026
@BF150 BF150 added the v4 label Mar 25, 2026
@BF150 BF150 linked an issue Mar 25, 2026 that may be closed by this pull request
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the maintainability and consistency of the details component's styling. It achieves this by reducing the specificity of CSS rules in the base component, leveraging shared styling mixins, and simplifying theme-specific declarations. The changes aim to make the component's appearance more predictable and easier to manage across different themes.

Highlights

  • Styling Refactor: Refactored the base details component styles to remove overly specific rules for the heading button, promoting cleaner and more reusable CSS.
  • Shared Mixin Integration: Integrated the kol-button-styles mixin into the details component's base stylesheet, standardizing button styling.
  • Theme Style Simplification: Simplified theme-specific styles in default/src/components/details.scss by using the border-bottom shorthand property.
  • Redundant Style Removal: Removed an unnecessary border-bottom: 0; reset from kern/src/components/details.scss, streamlining theme styles.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the styling of the kol-details component. It introduces a shared button mixin for kol-button-styles in packages/components/src/components/details/style.scss, removing previously inline button-related styles. The default theme's details.scss is updated to use a shorthand border-bottom property for the label, setting it to 3px solid #000. Concurrently, a specific border-bottom: 0; rule for kol-span__label is removed from the kern theme's details.scss, streamlining the styling approach. There are no review comments to address.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

🚀 MCP preview deployed to Vercel: https://kolibri-5kyb757ae-public-ui-kolibri-mcp.vercel.app

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2026

@BF150 BF150 marked this pull request as ready for review March 26, 2026 10:46
deleonio
deleonio previously approved these changes Mar 26, 2026
@BF150 BF150 dismissed deleonio’s stale review March 26, 2026 18:03

The merge-base changed after approval.

@deleonio deleonio merged commit 43d1fcd into develop Mar 26, 2026
11 checks passed
@deleonio deleonio deleted the fix/9867-details-component-less-specific-styles branch March 26, 2026 18:04
@publicuibot publicuibot bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Details component - to specific styles

2 participants