Conversation
…mponents to Skeleton Blueprint architecture
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new agent instruction file, migrate-to-skeleton.agent.md, which provides a comprehensive guide for refactoring legacy components into the Skeleton Blueprint architecture. The review feedback focuses on correcting technical inaccuracies within the documentation to align with the actual implementation of the BaseController and internal prop utilities. Key corrections include updating the controller constructor to accept setState and getState functions, renaming methods to getRenderProp and setRenderProp, and adjusting the createPropDefinition signature to match the architecture specification.
|
Netlify Draft Deployment |
There was a problem hiding this comment.
Pull request overview
This PR adds a new GitHub agent specification (migrate-to-skeleton) intended to guide systematic migrations of legacy Stencil components to KoliBri’s Skeleton Blueprint architecture.
Changes:
- Introduces
.github/agents/migrate-to-skeleton.agent.mdwith a phased migration workflow (analysis → props-first → refactor → dead-code removal → validation). - Adds embedded architecture guidance, templates (gap analysis), pitfalls, and a pre-review checklist to standardize refactors.
|
|
||
| ## Argument: $ARGUMENTS | ||
|
|
||
| The argument specifies which component to migrate (e.g. `card`, `tooltip`, `alert`). |
There was a problem hiding this comment.
bitte nur vorbilder nennen
| // Arrow property — ref setter | ||
| public setButtonRef = (element?: HTMLButtonElement): void => { /* ... */ }; | ||
| public constructor(setState: SetStateFn<MyApi>, getState: GetStateFn<MyApi>) { | ||
| super(myPropsConfig, setState, getState); |
There was a problem hiding this comment.
das ist die falsche reihenfolge
This pull request introduces a new agent specification,
migrate-to-skeleton, for systematically migrating legacy KoliBri web components to the Skeleton Blueprint architecture. The agent provides a comprehensive, step-by-step process to ensure components are refactored according to architectural standards, with a strong emphasis on maintainability, traceability, and code reduction.Key additions and improvements:
Agent Specification and Migration Procedure
.github/agents/migrate-to-skeleton.agent.md, a detailed Markdown file that defines themigrate-to-skeletonagent. This agent guides developers through analyzing, planning, implementing, and validating the migration of legacy components to the Skeleton architecture.Architecture and Best Practices Reference
ARC42.mdand provides reminders for common pitfalls, ensuring consistent application of patterns and conventions.