Skip to content

Add dependency_upgrade flag to copy API#4369

Open
guylain-lavoie wants to merge 1 commit intopulp:mainfrom
guylain-lavoie:add-dependency-upgrade-to-copy
Open

Add dependency_upgrade flag to copy API#4369
guylain-lavoie wants to merge 1 commit intopulp:mainfrom
guylain-lavoie:add-dependency-upgrade-to-copy

Conversation

@guylain-lavoie
Copy link
Copy Markdown

When dependency_upgrade=True, the solver resolves transitive dependencies to their latest available versions instead of preferring versions already present in the destination repository. This is achieved by setting SOLVER_FLAG_FOCUS_INSTALLED=0 and SOLVER_FLAG_FOCUS_BEST=1 in libsolv.

ref #4368

Assisted By: Claude (Anthropic)

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

@guylain-lavoie guylain-lavoie marked this pull request as draft March 12, 2026 14:00
@pedro-psb
Copy link
Copy Markdown
Member

@guylain-lavoie This is failing the lint job. Please, use the lint requirements to format with black and check with flake8.

@guylain-lavoie guylain-lavoie force-pushed the add-dependency-upgrade-to-copy branch from a46d619 to 60b8512 Compare March 17, 2026 19:47
@pedro-psb
Copy link
Copy Markdown
Member

@guylain-lavoie Still failing linting

When dependency_upgrade=True, the solver resolves transitive dependencies
to their latest available versions instead of preferring versions already
present in the destination repository. This is achieved by setting
SOLVER_FLAG_FOCUS_INSTALLED=0 and SOLVER_FLAG_FOCUS_BEST=1 in libsolv.

ref pulp#4368

Assisted By: Claude (Anthropic)
@guylain-lavoie guylain-lavoie force-pushed the add-dependency-upgrade-to-copy branch from 60b8512 to 85fab09 Compare March 19, 2026 13:08
@guylain-lavoie
Copy link
Copy Markdown
Author

guylain-lavoie commented Mar 19, 2026

@pedro-psb My mistake, somehow the fix did not made it to the branch.
black no longer identifies any issue and flake8 was already ok.
Sorry about that.

@pedro-psb pedro-psb linked an issue Mar 19, 2026 that may be closed by this pull request
@pedro-psb
Copy link
Copy Markdown
Member

@guylain-lavoie Is this ready for review? It's marked as draft.

@guylain-lavoie guylain-lavoie marked this pull request as ready for review April 23, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dependency_upgrade flag to copy

2 participants