Open
Conversation
7cc59ef to
3b30cb0
Compare
Mark tests that rely on global state as serial-execution-only Assisted-By: claude-opus-4.6
3b30cb0 to
c223d00
Compare
ggainey
requested changes
Mar 25, 2026
| assert rpm_repository_api.list().count == existing_repos | ||
|
|
||
|
|
||
| # Runs orphan cleanup to create a content-free zone; conflicts with parallel tests |
Contributor
There was a problem hiding this comment.
In this case, it's not the orphan-cleanup that causes a race - it's the window between 369-404 where som eother test creating a repo will cause the assert to fail. Let's change the comment to be more-correct to avoid confusing Future Us
Contributor
|
Note that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark tests that rely on global state as serial-execution-only
Assisted-By: claude-opus-4.6
📜 Checklist
See: Pull Request Walkthrough