Skip to content

(Hopefully) resolve flaky tests#4396

Open
dralley wants to merge 1 commit intopulp:mainfrom
dralley:fix-flaky-tests
Open

(Hopefully) resolve flaky tests#4396
dralley wants to merge 1 commit intopulp:mainfrom
dralley:fix-flaky-tests

Conversation

@dralley
Copy link
Copy Markdown
Contributor

@dralley dralley commented Mar 24, 2026

Mark tests that rely on global state as serial-execution-only

Assisted-By: claude-opus-4.6

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Mark tests that rely on global state as serial-execution-only

Assisted-By: claude-opus-4.6
@dralley dralley enabled auto-merge (rebase) March 24, 2026 19:40
assert rpm_repository_api.list().count == existing_repos


# Runs orphan cleanup to create a content-free zone; conflicts with parallel tests
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, it's not the orphan-cleanup that causes a race - it's the window between 369-404 where som eother test creating a repo will cause the assert to fail. Let's change the comment to be more-correct to avoid confusing Future Us

@ggainey
Copy link
Copy Markdown
Contributor

ggainey commented Mar 25, 2026

Note that test_create_missing_repos will continue to occasionally fail with the "same content from different repos" deadlock. But these changes will make other tests more reliable, so it's definitely still worth doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants