This repository was archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2538) Don't save core and legacy facts in collection if they have no value#441
Merged
Filipovici-Andrei merged 6 commits intomasterfrom Apr 13, 2020
Merged
(FACT-2538) Don't save core and legacy facts in collection if they have no value#441Filipovici-Andrei merged 6 commits intomasterfrom
Filipovici-Andrei merged 6 commits intomasterfrom
Conversation
Filipovici-Andrei
suggested changes
Apr 9, 2020
Contributor
Filipovici-Andrei
left a comment
Filipovici-Andrei
left a comment
There was a problem hiding this comment.
Nice, at least one unit test would be better😆
Contributor
Author
|
Added unit tests. |
BogdanIrimie
changed the title
BogdanIrimie
commented
Apr 9, 2020
Filipovici-Andrei
suggested changes
Apr 10, 2020
oanatmaria
reviewed
Apr 12, 2020
oanatmaria
approved these changes
Apr 13, 2020
Filipovici-Andrei
approved these changes
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.