Skip to content
This repository was archived by the owner on Jun 19, 2020. It is now read-only.

(FACT-2562) Correctly load custom and external fact directories#458

Merged
BogdanIrimie merged 4 commits intomasterfrom
FACT-2562-2
Apr 21, 2020
Merged

(FACT-2562) Correctly load custom and external fact directories#458
BogdanIrimie merged 4 commits intomasterfrom
FACT-2562-2

Conversation

@BogdanIrimie
Copy link
Copy Markdown
Contributor

No description provided.

@BogdanIrimie BogdanIrimie requested review from a team April 16, 2020 12:46
Comment thread spec/facter/facter_spec.rb Outdated
@@ -286,7 +286,7 @@

describe '#search_path' do
it 'sends call to LegacyFacter' do
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test description is now wrong

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test description

Comment thread spec/facter/facter_spec.rb Outdated
@@ -302,7 +302,7 @@

describe '#search_external_path' do
it 'sends call to LegacyFacter' do
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test description is now wrong

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test description

@oanatmaria oanatmaria added the bugfix Something isn't working label Apr 21, 2020
@BogdanIrimie BogdanIrimie merged commit 8840db2 into master Apr 21, 2020
@oanatmaria oanatmaria deleted the FACT-2562-2 branch April 21, 2020 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants