(FACT-2569) Run acceptance tests on Ubuntu GitHub actions

.github/actions/presuite.sh

@@ -0,0 +1,48 @@
+#!/bin/sh -x
+
+export DEBIAN_DISABLE_RUBYGEMS_INTEGRATION=no_wornings
+export PATH=/opt/puppetlabs/bin/:/opt/puppetlabs/puppet/bin:$PATH
+
+cwd=$(pwd)
+
+printf '\nInstall bundler\n\n'
+gem install bundler
+
+printf '\nInstall facter 3 acceptance dependencies\n\n'
+cd $cwd/$FACTER_3_ROOT/acceptance && bundle install
+
+printf '\nInstall custom beaker\n\n'
+cd $cwd/$BEAKER_ROOT
+gem build beaker.gemspec
+gem install beaker-*.gem --bindir /bin
+
+printf '\nBeaker provision\n\n'
+cd $cwd/$FACTER_3_ROOT/acceptance
+beaker init -h ubuntu1804-64a{hypervisor=none\,hostname=localhost} -o config/aio/options.rb
+beaker provision
+
+printf '\nBeaker pre-suite\n\n'
+BP_ROOT=`bundle info beaker-puppet --path`
+beaker exec pre-suite --pre-suite $BP_ROOT/setup/aio/010_Install_Puppet_Agent.rb
+
+printf '\nConfigure facter 4 as facter 3\n\n'
+puppet config set facterng true
+
+cd $cwd/$FACTER_4_ROOT
+puppet_gem_command=/opt/puppetlabs/puppet/bin/gem
+$puppet_gem_command build agent/facter-ng.gemspec
+$puppet_gem_command uninstall facter-ng
+$puppet_gem_command install -f facter-ng-*.gem
+
+cd /opt/puppetlabs/puppet/bin
+mv facter-ng facter
+
+printf "\nFacter version\n\n"
+facter --version
+
+printf "\Puppet facts facter version\n\n"
+puppet facts | grep facterversion
+
+printf '\nBeaker tests\n\n'
+cd $cwd/$FACTER_3_ROOT/acceptance
+beaker exec tests --test-tag-exclude=server,facter_3 --test-tag-or=risk:high,audit:high 2>&1

.github/workflows/ci.yml

@@ -0,0 +1,47 @@
+---
+name: GitHub hosted facter CI
+
+on: [pull_request]
+
+jobs:
+  ci:
+    name: Run acceptance tests
+    runs-on: ubuntu-latest
+    env:
+      FACTER_3_ROOT: facter_3
+      FACTER_4_ROOT: facter_4
+      BEAKER_ROOT: beaker
+      SHA: latest
+
+    steps:
+      - name: Checkout current PR
+        uses: actions/checkout@v2
+        with:
+          path: facter_4
+
+      - name: Clone facter 3 repo
+        uses: actions/checkout@v2
+        with:
+          repository: puppetlabs/facter
+          ref: skip_failures_on_ng
+          path: facter_3
+
+      - name: Clone Mihai's beaker fork
+        uses: actions/checkout@v2
+        with:
+          repository: mihaibuzgau/beaker
+          ref: master
+          path: beaker
+
+      - name: Install Ruby 2.6.x
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '2.6'
+
+      - name: Fix permissions
+        run: |
+          sudo chmod a-w /opt /home/runner /usr/share
+          sudo chmod -R a-w /usr/share/rust /home/runner/.config
+
+      - name: Run acceptance tests
+        run: sudo -E bash -c facter_4/.github/actions/presuite.sh

lib/facter.rb

@@ -238,7 +238,7 @@ def version
     #
     # @api private
     def to_user_output(cli_options, *args)
-      init_cli_options(cli_options)
+      init_cli_options(cli_options, args)
       logger.info("executed with command line: #{ARGV.drop(1).join(' ')}")
       log_blocked_facts
 
@@ -272,7 +272,7 @@ def logger
       @logger ||= Log.new(self)
     end
 
-    def init_cli_options(options)
+    def init_cli_options(options, args)
       options = options.map { |(k, v)| [k.to_sym, v] }.to_h
       Facter::Options.init_from_cli(options, args)
     end