This repository was archived by the owner on Jun 19, 2020. It is now read-only.
(FACT-2636) Set external as fact_type for environment variable facts.#537
Merged
BogdanIrimie merged 1 commit intomasterfrom May 29, 2020
Merged
(FACT-2636) Set external as fact_type for environment variable facts.#537BogdanIrimie merged 1 commit intomasterfrom
BogdanIrimie merged 1 commit intomasterfrom
Conversation
|
Would it be possible to get this released soon? PDB tests are still failing because of it. If not, please let me know, so I can revert our switch to testing with Facter 4 in PDB and puppetserver. |
Magisus
approved these changes
May 28, 2020
Magisus
left a comment
Magisus
left a comment
There was a problem hiding this comment.
I verified that this fix resolves the issue, using the repro case in the ticket.
Contributor
Author
|
@Magisus released Facter 4.0.25 today, please give it a try. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 7, 2020
Update ruby-facter to 4.0.25. ## [4.0.25](https://github.com/puppetlabs/facter-ng/tree/4.0.25) (2020-05-29) ### Fixed - \(FACT-2636\) Set external as fact\_type for environment variable facts. [\#537](puppetlabs/facter-ng#537) ([IrimieBogdan](https://github.com/IrimieBogdan)) ## [4.0.24] (2020-05-26) ### Added - \(FACT-2605\) Add vmware resolver [\#525](puppetlabs/facter-ng#525) ([oanatmaria](https://github.com/oanatmaria)) - \(FACT-2604\) Add virt-what resolver [\#523](puppetlabs/facter-ng#523) ([oanatmaria](https://github.com/oanatmaria))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment variable external facts were missing
fact_type: :externaloption, and because of this they were ignored when resolving facts. This is required sinceFacter 4.0.22as external facts are identified based onfact_typeoption.