Facter doesn't report all chassis types from the SMBIOS specification.

[jandrunas-vast]

Describe the Bug

I was using the dmi.chassis.type fact in a puppet manifest and noticed that it was failing to properly report on a new machine. Looking at the code here it seems it only reports on some specific values. According to the SMBIOS specification there are several other possible options. Pages 39 and 40 enumerate them in this document.

Expected Behavior

Facter should report the value for the chassis type if it is a valid option as specified in the SMBIOS specifications.

Steps to Reproduce

Steps to reproduce the behavior:

On a machine that reports a chassis type not enumerated explicitly in the facter code linked above, run facter dmi.chassis.type and see that it doesn't report anything, compare the output to dmidecode -s chassis-type which will output an appropriate value.

Environment

• Version: any
• Platform: any

Additional Context

[AriaXLi]

Hi @jandrunas-vast thank you for reporting this issue! I believe this was addressed in Facter 4.13.0 so I'm closing this. Feel free to checkout these release notes for more information: https://help.puppet.com/core/current/Content/PuppetCore/FacterReleaseNotes/release_notes_facter.htm#Facter4130.