(FACT-2040) Added solaris memory resolver#1999
Merged
BogdanIrimie merged 1 commit intopuppetlabs:4.xfrom Aug 4, 2020
Merged
Conversation
oanatmaria
reviewed
Jul 28, 2020
oanatmaria
reviewed
Jul 28, 2020
oanatmaria
reviewed
Jul 28, 2020
|
CLA signed by all contributors. |
sebastian-miclea
force-pushed
the
FACT-2040
branch
from
424c0bc to
97bbdae
Compare
sebastian-miclea
force-pushed
the
FACT-2040
branch
from
97bbdae to
46faa70
Compare
BogdanIrimie
approved these changes
Aug 4, 2020
| return unless pagesize != 0 | ||
|
|
||
| total = kstats['physmem'].to_i * pagesize | ||
| free = kstats['pagesfree'].to_i * pagesize |
Contributor
There was a problem hiding this comment.
I think this will log the pagesize 3 times. Probably
unless @fact_list[:pagesize] @fact_list[:pagesize] ||= Facter::Core::Execution.execute('pagesize', logger: log).strip.to_i log.debug("Pagesize: #{@pagesize}") @fact_list[:pagesize] in the pagesize method will work better
igalic
reviewed
Aug 5, 2020
|
|
||
| def sys | ||
| sys = {} | ||
| output = Facter::Core::Execution.execute('/usr/bin/kstat -m unix -n system_pages', logger: log).strip |
There was a problem hiding this comment.
given that freebsd doesn't have this utility
|
|
||
| def swap | ||
| swap_hash = {} | ||
| output = Facter::Core::Execution.execute('/usr/sbin/swap -l', logger: log).strip |
There was a problem hiding this comment.
nor this one
we need a freebsd version of this resolver now too
Contributor
|
@igalic Yes, adding memory and dmi fact is high on my Puppet todo-list: it's the only piece missing so that Facter 4 can be used as a drop-in replacement to Facter 3, at least on my computer 😛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.