Skip to content

(FACT-2722) Add disks fact for Solaris#2027

Merged
BogdanIrimie merged 2 commits intopuppetlabs:4.xfrom
Filipovici-Andrei:FACT-2722
Aug 18, 2020
Merged

(FACT-2722) Add disks fact for Solaris#2027
BogdanIrimie merged 2 commits intopuppetlabs:4.xfrom
Filipovici-Andrei:FACT-2722

Conversation

@Filipovici-Andrei
Copy link
Copy Markdown
Contributor

No description provided.

@Filipovici-Andrei Filipovici-Andrei added the enhancement New feature or enhancement label Aug 12, 2020
@Filipovici-Andrei Filipovici-Andrei requested review from a team August 12, 2020 16:19
@Filipovici-Andrei Filipovici-Andrei force-pushed the FACT-2722 branch 2 times, most recently from dfcdeef to 974c610 Compare August 12, 2020 16:36
@Filipovici-Andrei
Copy link
Copy Markdown
Contributor Author

jenkins please test this on all

Copy link
Copy Markdown

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the restructuring of the code a separate commit or even pull request, cuz it's hard to follow what's going on given the commit message

and there's not much more explanation in FACT-2722 either

@puppetcla
Copy link
Copy Markdown

CLA signed by all contributors.

@Filipovici-Andrei
Copy link
Copy Markdown
Contributor Author

Sure @igalic. That's a reasonable request.

Comment thread lib/facter/resolvers/load_averages.rb Outdated
Comment thread lib/facter/resolvers/solaris/disks.rb Outdated
@BogdanIrimie BogdanIrimie merged commit cb3e909 into puppetlabs:4.x Aug 18, 2020
@Filipovici-Andrei Filipovici-Andrei deleted the FACT-2722 branch August 19, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants