(FACT-2816) - Fix ec2 fact issues when on non ec2 systems

[logicminds]

• previously when ec2 facts are executed the check_product_name
  was run which incorrectly returned a hash of values when the product
  name did not exist in the hypervisor hash. This is an edge case
  on linux systems not in ec2.

This caused errors messages how hashes cannot be converted since the expected value was supposed to be a string.

-E, [2020-09-27T18:11:08.838323 #26186] ERROR -- : Facter::InternalFactManager - undefined method `each' for nil:NilClass

lib/ruby/gems/2.7.0/gems/facter-4.0.39/lib/facter/facts/linux/ec2_userdata.rb:21: warning: deprecated Object#=~ is called on Hash; it always returns nil
E, [2020-09-27T18:11:08.916334 #26186] ERROR -- : Facter::InternalFactManager - undefined method `map' for nil:NilClass

E, [2020-09-27T18:11:08.916802 #26186] ERROR -- : Facter::InternalFactManager - undefined method `each' for nil:NilClass

[logicminds]

🏷️ bugfix
🏷️ community

Adding labels are greyed out and I don't have permission to add.

[oanatmaria]

Hi @logicminds,

First of all i want to thank you for your contribution and for reporting this issue. I've created this ticket to track this bug.

Could you please fill up some details in the ticket above (like with what version of Facter this bug was found, the os you found the issue on and a short description about the wrong output of Facter)? Also can you change the commit message to indicate to that Jira ticket, something like: (FACT-2816) Fix ec2 fact on non ec2 systems?

[puppetcla]

CLA signed by all contributors.

[logicminds]

All items have been addressed. Please review. @oanatmaria