PE 2023.8.0 uses legacy master section in puppet.conf

[bastelfreak]

Describe the Bug

The [master] section in puppet.conf is deprecated, [server] is the successor. Given the following puppet.conf [server] section without [master] section:

[server]
node_terminus = classifier
storeconfigs = true
storeconfigs_backend = puppetdb
reports = puppetdb
certname = ***
always_retry_plugins = false
disable_i18n = false
versioned_environment_dirs = true
report_configured_environmentpath = true

running the puppet agent produces:

[server]
node_terminus = classifier
storeconfigs = true
storeconfigs_backend = puppetdb
reports = puppetdb
certname = ***
always_retry_plugins = false
disable_i18n = false
versioned_environment_dirs = true
report_configured_environmentpath = true

[master]
node_terminus = classifier
storeconfigs = true
storeconfigs_backend = puppetdb
reports = puppetdb
always_retry_plugins = false
disable_i18n = false
versioned_environment_dirs = true
report_configured_environmentpath = true

agent output:

Notice: /Stage[main]/Puppet_enterprise::Profile::Master::Classifier/Pe_ini_setting[node_terminus]/ensure: created (corrective)
Info: /Stage[main]/Puppet_enterprise::Profile::Master::Classifier/Pe_ini_setting[node_terminus]: Scheduling refresh of Service[pe-puppetserver]
Info: Class[Puppet_enterprise::Profile::Master::Classifier]: Scheduling refresh of Service[pe-puppetserver]
Notice: /Stage[main]/Puppet_enterprise::Profile::Master::Puppetdb/Pe_ini_setting[storeconfigs]/ensure: created (corrective)
Notice: /Stage[main]/Puppet_enterprise::Profile::Master::Puppetdb/Pe_ini_setting[storeconfigs_backend]/ensure: created (corrective)
Notice: /Stage[main]/Puppet_enterprise::Profile::Master::Puppetdb/Pe_ini_subsetting[reports_puppetdb]/ensure: created (corrective)
Info: Class[Puppet_enterprise::Profile::Master::Puppetdb]: Scheduling refresh of Service[pe-puppetserver]
Notice: /Stage[main]/Puppet_enterprise::Master/Pe_ini_setting[puppetserver puppetconf always_retry_plugins]/ensure: created (corrective)
Info: /Stage[main]/Puppet_enterprise::Master/Pe_ini_setting[puppetserver puppetconf always_retry_plugins]: Scheduling refresh of Service[pe-puppetserver]
Notice: /Stage[main]/Puppet_enterprise::Master/Pe_ini_setting[puppetconf disable_i18n setting]/ensure: created (corrective)
Info: /Stage[main]/Puppet_enterprise::Master/Pe_ini_setting[puppetconf disable_i18n setting]: Scheduling refresh of Service[pe-puppetserver]
Notice: /Stage[main]/Puppet_enterprise::Profile::Master/Pe_ini_setting[toggle versioned environment dirs]/ensure: created (corrective)
Info: /Stage[main]/Puppet_enterprise::Profile::Master/Pe_ini_setting[toggle versioned environment dirs]: Scheduling refresh of Service[pe-puppetserver]
Notice: /Stage[main]/Puppet_enterprise::Profile::Master/Pe_ini_setting[set report_configured_environmentpath]/ensure: created (corrective)
Info: /Stage[main]/Puppet_enterprise::Profile::Master/Pe_ini_setting[set report_configured_environmentpath]: Scheduling refresh of Service[pe-puppetserver]
Notice: /Stage[main]/Puppet_enterprise::Master::Puppetserver/Puppet_enterprise::Trapperkeeper::Pe_service[puppetserver]/Service[pe-puppetserver]: Triggered 'refresh' from 7 events

Expected Behavior

Don't write into deprecated sections.

Steps to Reproduce

• Install PE 2023.8.0
• rename master section or delete it
• run puppet agent

Environment

• EL8
• PE 2023.8.0

Additional Context

The master section is hardcoded. I would have provided a patch or pull request, but the license doesn't allow it and the git repo is private.