Add rgen as a runtime dependency

[rnelson0]

When using puppet-strings with a module that otherwise does not specify rgen in its Gemfile, this error was observed:

$ bundle exec puppet strings generate ./manifests/*.pp
Error: The 'rgen' gem must be installed in order to use this face.
Error: Try 'puppet help strings generate' for usage

Adding rgen to the Gemfile allows puppet strings to work, so it seems like a valid runtime dependency.

[bastelfreak]

Can anybody explain the difference between 'bundle exec puppet strings generate' and 'bundle exec rake strings:generate'? The rake task works fine without the rgen gem (or is it vendored somewhere?)

bastelfreak@bastelfreak-ws ~/modulesync_config/modules/puppet-cassandra $ bundle list rgen
Could not find gem 'rgen'.
bastelfreak@bastelfreak-ws ~/modulesync_config/modules/puppet-cassandra $ gem list rgen

*** LOCAL GEMS ***


bastelfreak@bastelfreak-ws ~/modulesync_config/modules/puppet-cassandra $ bundle list puppet-strings
/home/bastelfreak/modulesync_config/modules/puppet-cassandra/.vendor/ruby/2.4.0/gems/puppet-strings-1.1.1
bastelfreak@bastelfreak-ws ~/modulesync_config/modules/puppet-cassandra $ bundle exec rake strings:generate
Could not find semantic_puppet gem, falling back to internal functionality. Version checks may be less robust.
[warn]: The type of the @param tag for parameter 'manage_config_file' does not match the parameter type specification near manifests/init.pp:130: ignoring in favor of parameter type information.
[warn]: Unknown tag @resolution in file `lib/facter/cassandrarelease.rb` near line 9
[warn]: Unknown tag @caveats in file `lib/facter/cassandrarelease.rb` near line 9
[warn]: Unknown tag @caveats in file `lib/facter/cassandramajorversion.rb` near line 6
[warn]: Unknown tag @caveats in file `lib/facter/cassandraminorversion.rb` near line 6
[warn]: Unknown tag @caveats in file `lib/facter/cassandrapatchversion.rb` near line 6
Files:                   29
Modules:                  0 (    0 undocumented)
Classes:                  0 (    0 undocumented)
Constants:                0 (    0 undocumented)
Attributes:               0 (    0 undocumented)
Methods:                  8 (    0 undocumented)
Puppet Classes:          13 (    0 undocumented)
Puppet Defined Types:     8 (    0 undocumented)
Puppet Types:             0 (    0 undocumented)
Puppet Providers:         0 (    0 undocumented)
Puppet Functions:         0 (    0 undocumented)
 100.00% documented
bastelfreak@bastelfreak-ws ~/modulesync_config/modules/puppet-cassandra $

Is the rgen gem actually needed? Or is that an old dependency and could be removed?

[hlindberg]

rgen gem is needed for puppet < 5.0.0 when it was replaced with our own implementation.

[bastelfreak]

Thanks for the details @hlindberg