Skip to content

Commit 376dc8b

Browse files
author
Jeff McCune
committed
Merge branch 'ryanuber-rpm-file-attr-workaround'
closes #1385 By Ryan Uber: * ryanuber-rpm-file-attr-workaround: Work-around for RH Bugzilla 681540 (defattr overrides in-line attr)
2 parents 631e3f2 + ea8901e commit 376dc8b

1 file changed

Lines changed: 12 additions & 5 deletions

File tree

ext/redhat/puppet.spec.erb

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,11 +192,7 @@ mkdir -p %{buildroot}%{_sysconfdir}/%{name}/modules
192192
%{_datadir}/emacs
193193
%{_datadir}/vim
194194
%{_datadir}/%{name}
195-
# These need to be owned by puppet so the server can
196-
# write to them
197-
%attr(-, puppet, puppet) %{_localstatedir}/run/puppet
198-
%attr(0750, puppet, puppet) %{_localstatedir}/log/puppet
199-
%attr(-, puppet, puppet) %{_localstatedir}/lib/puppet
195+
# man pages
200196
%{_mandir}/man5/puppet.conf.5.gz
201197
%{_mandir}/man8/puppet.8.gz
202198
%{_mandir}/man8/puppet-agent.8.gz
@@ -232,6 +228,14 @@ mkdir -p %{buildroot}%{_sysconfdir}/%{name}/modules
232228
%{_mandir}/man8/puppet-resource_type.8.gz
233229
%{_mandir}/man8/puppet-secret_agent.8.gz
234230
%{_mandir}/man8/puppet-status.8.gz
231+
# These need to be owned by puppet so the server can
232+
# write to them. The separate %defattr's are required
233+
# to work around RH Bugzilla 681540
234+
%defattr(-, puppet, puppet, 0755)
235+
%{_localstatedir}/run/puppet
236+
%defattr(-, puppet, puppet, 0750)
237+
%{_localstatedir}/log/puppet
238+
%{_localstatedir}/lib/puppet
235239

236240
%files server
237241
%defattr(-, root, root, 0755)
@@ -375,6 +379,9 @@ rm -rf %{buildroot}
375379
* <%= Time.now.strftime("%a %b %d %Y") %> Puppet Labs Release <info@puppetlabs.com> - <%= @rpmversion %>-<%= @rpmrelease %>
376380
- Build for <%= @version %>
377381

382+
* Wed Jan 9 2013 Ryan Uber <ru@ryanuber.com> - 3.1.0-0.1rc1
383+
- Work-around for RH Bugzilla 681540
384+
378385
* Tue Dec 18 2012 Matthaus Owens <matthaus@puppetlabs.com>
379386
- Remove for loop on examples/ code which no longer exists. Add --no-run-if-empty to xargs invocations.
380387

0 commit comments

Comments
 (0)