(#17866) RPM spec file work-around for RH Bugzilla 681540 (defattr overrides in-line attr)#1385
Closed
ryanuber wants to merge 1 commit intopuppetlabs:masterfrom
ryanuber:rpm-file-attr-workaround
Closed
(#17866) RPM spec file work-around for RH Bugzilla 681540 (defattr overrides in-line attr)#1385ryanuber wants to merge 1 commit intopuppetlabs:masterfrom ryanuber:rpm-file-attr-workaround
ryanuber wants to merge 1 commit intopuppetlabs:masterfrom
ryanuber:rpm-file-attr-workaround
Conversation
Contributor
|
@haus @MosesMendoza does this look good to you guys? |
Contributor
|
👍 |
Contributor
|
Merged into master as ea8901e. This should be released in 3.1.0. Thanks again for the contribution! -Jeff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once puppet #17866 was resolved (Puppet RPM's break themselves), yet another RPM problem surfaced. This issue is isolated to builds on RHEL 6.x due to the newer version of rpmbuild (4.8 on RHEL6). Previous versions of rpmbuild (4.4 from RHEL5.x) did not have this issue.
What the issue boils down to is that using the
%attrtag after a%defattrtag has no effect.To illustrate, the file attributes of the /test directory would come out as 0755 in the below example:
The work-around simply involves using
%defattrmultiple times rather than trying to override it with%attrin-line.