(MAINT) Remove Travis before_install step#6482
(MAINT) Remove Travis before_install step#6482joshcooper merged 1 commit intopuppetlabs:4.10.xfrom michaeltlombardi:MAINT/master/travis-update
Conversation
|
CLA signed by all contributors. |
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
👍
$ ruby --version
ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-linux]
$ rvm --version
rvm 1.29.3 (latest) by Michal Papis, Piotr Kuczynski, Wayne E. Seguin [https://rvm.io]
$ bundle --version
Bundler version 1.16.0
$ gem --version
Also looks like the earlier change was added in https://tickets.puppetlabs.com/browse/PUP-7920 to workaround travis-ci/travis-ci#8357, which is now fixed.
|
@Iristyle you were mentioning bundler 1.16.0 issues earlier. Any reason to hold off merging this? |
There was a problem hiding this comment.
Lets retarget at 4.10.x
Could also reference the info @joshcooper mentioned in commit message about the original ticket / TravisCI issue for the sake of posterity (or just revert original PR).
|
Also see same effort in modules-land: |
|
Commit message updated to include previous tickets/issues. Working on retargeting. |
Prior to this commit the Travis config included a `before_install` step, added in https://tickets.puppetlabs.com/browse/PUP-7920, which installed bundler at `1.15.4` to workaround travis-ci/travis-ci#8357, which is fixed. We discovered during research for MODULES-6339 that Travis now keeps their matrices updated with the latest compatible bundler install. For all of the builds in this matrix Travis is currently using bundler `1.16.0` and the builds pass successfully. This maintenance commit removes the pinned-version install of bundler and instead returns to relying on Travis to build and maintain images with compatible versions. This also follows the advice in the comment in the config file on this step.
|
Interestingly, this build is failing on Ruby Any thoughts? |
|
Travis gets confused sometimes when you retarget an earlier branch, as it shouldn't be testing ruby 2.4.0 against the 4.10.x branch (since we didn't add ruby 2.4.0 support until 5.x). I'm going to close the PR and reopen, so it tests the right combinations. |
|
Thanks, @joshcooper! That makes sense. |
|
LGTM, @Iristyle want to merge? |
4 participants
Prior to this commit the Travis config included a
before_installstep which installed bundler at
1.15.4to resolve an issue withcompatibility in the matrices for Ruby
1.9.3. However, duringresearch for MODULES-6339 it was discovered that Travis now keeps
their matrices updated with the latest compatible bundler install.
For all of the builds in this matrix Travis is currently using
bundler
1.16.0and the builds pass successfully.This maintenance commit removes the pinned-version install of
bundler and instead returns to relying on Travis to build and
maintain images with compatible versions. This also follows the
advice in the comment in the config file on this step.