(PUP-10640) add github actions workflows on main#8352
Closed
Conversation
the following tests have been updated - spec/integration/util/windows/adsi_spec.rb:34 Was making the assumption that `Administrator` user is present. Changed to `Guest` since `Administrator` is not available in all setups. - spec/unit/file_system_spec.rb:870 `Puppet::FileSystem.expand_path` expands relative to the drive that Puppet is executed from. The expect here was making the assumption that Puppet tests are run form `SystemDrive` which is not always the case - spec/unit/provider/exec_spec.rb ENV['PATH'] is not correctly handled by Ruby. Use Pathname.cleanpath no normalize the path that is used in the `exec` resource
gimmyxd
force-pushed
the
PUP-10640_main
branch
from
db17252 to
8e9de20
Compare
gimmyxd
changed the title
gimmyxd
force-pushed
the
PUP-10640_main
branch
2 times, most recently
from
d7ce0bb to
76a9645
Compare
gimmyxd
force-pushed
the
PUP-10640_main
branch
from
76a9645 to
9c60d3e
Compare
|
CLA signed by all contributors. |
| describe '.[]' do | ||
| it 'should return string attributes as UTF-8' do | ||
| administrator = Puppet::Util::Windows::ADSI::User.new('Administrator') | ||
| administrator = Puppet::Util::Windows::ADSI::User.new('Guest') |
Contributor
There was a problem hiding this comment.
Suggested change
| administrator = Puppet::Util::Windows::ADSI::User.new('Guest') | |
| guest = Puppet::Util::Windows::ADSI::User.new('Guest') |
Contributor
Author
There was a problem hiding this comment.
added the suggested change in https://github.com/puppetlabs/puppet/pull/8351/files
I was thinking to have that merged first so the tests work on all environments. I'll update this PR after that gets merged
ciprianbadescu
approved these changes
Oct 2, 2020
Contributor
|
Sorry that didn't do what I wanted. I'm going to close this, merge master -> main and and rebase your change on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Travis was testing using jruby-9.2.8.0, but that is not available on GH actions and this is testing using jruby-9.2.9.0
extracted the first commit(dd11e0a) to run on appveyor and travis to make sure it not breaks anything: #8351