(PUP-11129) remove deleted environments from cache#8663
Merged
gimmyxd merged 1 commit intopuppetlabs:6.xfrom Jul 5, 2021
Merged
(PUP-11129) remove deleted environments from cache#8663gimmyxd merged 1 commit intopuppetlabs:6.xfrom
gimmyxd merged 1 commit intopuppetlabs:6.xfrom
Conversation
joshcooper
reviewed
Jun 30, 2021
joshcooper
approved these changes
Jun 30, 2021
Contributor
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
LGTM. Could you include some description about the behavior change in the commit message?
joshcooper
reviewed
Jul 2, 2021
Contributor
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
Looks like there's a conflict due to the reverted symbol/string change, otherwise looks good!
Previously, the cached environment list could return environments that were no longer accessible. This commits updates the code to remove from cache envrionments that are no longer on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the cached environment list could
return environments that were no longer accessible.
This commit updates the code to remove from
cache environments that are no longer on disk.