apache::servername parameter does nothing

[tedgarb]

Describe the Bug

The documentation for the apache::servername directive at https://forge.puppet.com/modules/puppetlabs/apache/reference#-apache--servername (source at https://github.com/puppetlabs/puppetlabs-apache/blob/main/manifests/init.pp#L307C1-L309C55) says that this "Sets the Apache server name via Apache's ServerName directive." However, the servername option is not used any further in init.pp, and in particular it does not get passed into the default or default-ssl vhosts.

Expected Behavior

The servername directive is used to set the servername directive in the default/default-ssl vhosts.

Steps to Reproduce

Steps to reproduce the behavior:

1. Set the servername directive, such as by

  servername => 'example.com',
  default_https_vhost => true,
}

2. Apply the config
3. Inspect the resulting 15-default-80.conf and 15-default-ssl-443.conf files, and see that ServerName is set to default instead of example.com

Environment

• Version 12.1.0
• Platform RHEL8/9

Additional Context

Changing this is going to involve some sort of breaking change, especially since the filename is set based on the servername value.