Make installation of unzip optional#141
Merged
sanfrancrisko merged 3 commits intopuppetlabs:masterfrom Mar 10, 2020
coolguydork:optional_unzip
Merged
Make installation of unzip optional#141sanfrancrisko merged 3 commits intopuppetlabs:masterfrom coolguydork:optional_unzip
sanfrancrisko merged 3 commits intopuppetlabs:masterfrom
coolguydork:optional_unzip
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=========================================
Coverage ? 44.23%
=========================================
Files ? 2
Lines ? 208
Branches ? 0
=========================================
Hits ? 92
Misses ? 116
Partials ? 0Continue to review full report at Codecov.
|
Contributor
Author
|
Hello, I'm not sure how to satisfy the last automated comment. Could someone please help me? |
Contributor
|
Thanks @haloflightleader for submitting the PR. Could you please add tests to verify the new parameter. |
Contributor
|
@haloflightleader Unit tests are added . Will merge it as soon as the Travis and the ad-hoc job runs green. |
sanfrancrisko
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the installation of the unzip package optional. Many systems install the unzip package separately. By hardcoding it, duplicate declaration errors arise in systems where this is true.