Skip to content

Adds default values for section#153

Closed
mrzarquon wants to merge 3 commits intopuppetlabs:masterfrom
mrzarquon:MODULES_1868_add_default
Closed

Adds default values for section#153
mrzarquon wants to merge 3 commits intopuppetlabs:masterfrom
mrzarquon:MODULES_1868_add_default

Conversation

@mrzarquon
Copy link
Copy Markdown

Our documentation says to use "" for section if you want top of file
global settings, this defaults to that assumption if the user doesn't
provide a section parameter at all.

Our documentation says to use "" for section if you want top of file
global settings, this defaults to that assumption if the user doesn't
provide a section parameter at all.
@hunner
Copy link
Copy Markdown
Contributor

hunner commented Mar 18, 2015

Could you update the README as well?

Comment thread README.markdown
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you actually say that it 'Defaults to ""' like the other parameters say?

@bmjen
Copy link
Copy Markdown
Contributor

bmjen commented Mar 30, 2015

Ping @mrzarquon. Thanks for the contribution. The fix looks good. However can you make a few updates?

  1. The doc update that @hunner requested? It should read something like...
  • section: The name of the INI file section in which the setting should be defined. Defaults to "", but you can explicitly add a global section --- settings that appear at the beginning of the file, before any named sections --- by specifying a section name of "".

Same applies to the subsetting definition.

  1. Please squash your commits down to 1 commit.
  2. Please rebase.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants