Honor default separator in set_config#545
Open
kajinamit wants to merge 1 commit intopuppetlabs:mainfrom
Open
Conversation
kajinamit
requested review from
a team,
bastelfreak,
ekohl and
smortex
as code owners
span786
force-pushed
the
fix544
branch
2 times, most recently
from
2e0848d to
694a6a9
Compare
... to use the consistent separator by default in all functions by default. Users can still override the separator by passing the separator argument when calling the function. Fixes: puppetlabs#544
Contributor
|
@kajinamit Please add the required test for the requested change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to use the consistent separator by default in all functions by default. Users can still override the separator by passing the separator argument when calling the function.
Fixes: #544
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
#544
Checklist
puppet apply)