Skip to content

Compatibility for Alpine linux#1049

Merged
eputnam merged 1 commit intomasterfrom
unknown repository
Mar 1, 2018
Merged

Compatibility for Alpine linux#1049
eputnam merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 6, 2018

No description provided.

@pmcmaw
Copy link
Copy Markdown
Contributor

pmcmaw commented Feb 15, 2018

Hey @Cisco87,
When merging this PR I would like to make you aware this will make the code base compatible with the module, however Puppet will not support this operating system. By support I mean we will not be running tests against this OS or providing bug fixes specific to this OS. I would like to make sure you are ok with this before I merge. 👍

@eputnam eputnam added the feature label Mar 1, 2018
@eputnam eputnam changed the title Adding support for Alpine linux Compatibility for Alpine linux Mar 1, 2018
@eputnam
Copy link
Copy Markdown
Contributor

eputnam commented Mar 1, 2018

@Cisco87 please see @pmcmaw 's comment. also, if you'd like to add an alpine docker nodeset in spec/acceptance/nodesets, feel free to do so!

@eputnam eputnam merged commit 8fd19b4 into puppetlabs:master Mar 1, 2018
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 9, 2018

Hello, sorry for the delay on the reply, I've been away from github a bit. I will try to maintain it updated with changes in both alpine/puppet-mysql, I use it every day so I should be quite able to catch any regression. I will have a look at acceptance testing approach, thanks for the merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants