Allow empty user passwords#1075
Conversation
|
@disappear89 Please add a test to account for an empty password |
|
@david22swan |
|
@disappear89 The test looks good, but your changes seem to have disappeared |
|
@david22swan That was by purpose to see if the test works. But travis build does not detect an error but it should. |
|
@david22swan Any idea? Someone else that could have a look at the test :) ? |
|
@disappear89 Have you tried manually setting an empty password to see what happens? |
|
@david22swan That`s working. We use the forged repo with my changes on our puppet setup and empty mysql passwords are possible ;) |
|
@disappear89 Have you tried entering an empty password without your changes? |
|
@david22swan Yes than the error Error: |
|
@disappear89 Can you recommit the actual changes so that I can see them |
|
@david22swan Done =) |
|
@disappear89 I apologize but after conferring with members of my team there has been some question on why you wish this functionality to be added. |
|
@david22swan No problem. We have setups where some users can connect without password but only via localhost. |
|
@disappear89 Could you add a docs change to reflect this added functionality?? |
|
@david22swan |
|
@david22swan Thanks |
https://tickets.puppetlabs.com/browse/MODULES-7187
Changes: Allow empty user / root password.
Before this PR: Can`t set empty passwords cause of the mysql_user provider failure:
Error: Only mysql_native_password (*ABCD...XXX) hashes are supported.
Error: /Stage[main]/Mysql::Server::Root_password/Mysql_user[root@localhost]/password_hash: change from [old password hash redacted] to [new password hash redacted] failed: Only mysql_native_password (*ABCD...XXX) hashes are supported.
After this PR: Can set empty passwords cause regex of mysql_user providers password check extended:
Info: /Stage[main]/Mysql::Server::Root_password/File[/root/.my.cnf]: Filebucketed /root/.my.cnf to puppet with sum 9d96b07caeee3d0e3e7fb49e0f891860
Notice: /Stage[main]/Mysql::Server::Root_password/File[/root/.my.cnf]/content: content changed '{md5}9d96b07caeee3d0e3e7fb49e0f891860' to '{md5}337598bf15a160df1e57d2d90d5bc426'
[root@vmxxxxxx ~]# cat /root/.my.cnf
MANAGED BY PUPPET
[mysql]
user=root
host=localhost
password=''
socket=/tmp/mysql.sock