fix install ordering for innodb data size#1160
Merged
david22swan merged 1 commit intopuppetlabs:masterfrom Apr 2, 2019
Merged
Conversation
Garamotte
approved these changes
Mar 6, 2019
Youbi42
approved these changes
Mar 6, 2019
boagg
approved these changes
Mar 6, 2019
Contributor
|
Any progress on this ? |
Member
|
@fe80 Thank you for your work and we are sorry that the module was broken for you for so long. |
|
Hello. Could you please describe why after this changes installation of mysql by this module with version 8.1.0 started to fail? datadir redeclared by $datadir not created before starting of configuring mysql package. |
Contributor
Author
|
Hello @yotles, We create the datadir before installation in a custom module to create a dedicated logical volume. I think this is why we have this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Since release 5.4.0 MySQL package was install with default configuration, and after the configuration was set.
So we can not change innodb data size configuration for example (the default size is 12Mo and if you change this size MySQL can't be restart).
Someone have notify this conportement on the commit: d13c06b
I think it's better to rollback the ordering, and eventually change the resource
/etc/mysql/conf.d/mysql.cnfin post-install class if it's needed