Enable module to not use default options

[morremeyer]

This PR enables you to either use:

• override_options as it was the case previously. Those options are merged with the default options
• options. Those options won’t be merged with the default options.

Both are mutually exclusive in usage, meaning that one of them has to be empty.

I wrote this PR because we want to get rid of the version specific configuration options as it makes our workflows for changes of default parameters in our profiles easier.

I wrote it like this so that it has clean semantics:

• override_options tells you that defaults are overridden
• options tells you that options will be set

Therefore, this PR is fully backwards compatible.

[sheenaajay]

Thanks @mauricemeyer for submitting the PR. Could you please incorporate comments. Thank you @bastelfreak for the valuable comments.

[morremeyer]

@sheenaajay Thanks for the reminder! I updated the PR, let’s see what @bastelfreak thinks :)

[sheenaajay]

Thank you @mauricemeyer .

[morremeyer]

The test for Puppet 5 failed, but it looks to me like a test problem?

I can’t restart the test, though.

[bastelfreak]

@mauricemeyer magic travis trick: close + reopen the PR will retrigger travis.

[morremeyer]

@bastelfreak Works like a charm, thanks.

[lionce]

close and reopen to rerun tests

[lionce]

Hello @mauricemeyer ,

It looks good to me! Thank you!
@bastelfreak thank you for your great review! :) Please re-check this

Cheers!