Allow backupcompress for xtrabackup profile#1196
Allow backupcompress for xtrabackup profile#1196carabasdaniel merged 4 commits intopuppetlabs:masterfrom Spuffnduff:patch-1
Conversation
|
Hi @Spuffnduff, This looks good, but would it be possible to add some tests to verify that this is working as intended and maybe squash the commits ? Once that's done I'll close #1154 and get this merged. Thanks. |
|
I'll look into squashing the commits. I may need some help in writing some tests but will reach out when the time comes. |
|
Hello @Spuffnduff , Please let us know if we can help you! Thank you! Cheers |
Update xtrabackup.sh.erb
Updated the backupcompress comment in the backup main profile
|
I think I performed enough squash cleanup for this PR. I noticed that there is a Travis test against this so it should rerun soon. If not I will look into it. |
|
Looking at the current .travis.yml file in my branch, it passes expect for Puppet v.4 which shouldn't matter. The current travis tests don't have that incorporated anymore (looking at the current master branch). |
Since TNAJanssen's PR has been stale, I forked from his repo and am attempting to get it active again and hopefully merged in.
If there is anything missing or I need to do more, please let me know as I'm new to this.