Skip to content

Allow backupcompress for xtrabackup profile#1196

Merged
carabasdaniel merged 4 commits intopuppetlabs:masterfrom
Spuffnduff:patch-1
Feb 17, 2020
Merged

Allow backupcompress for xtrabackup profile#1196
carabasdaniel merged 4 commits intopuppetlabs:masterfrom
Spuffnduff:patch-1

Conversation

@Spuffnduff
Copy link
Copy Markdown
Contributor

Since TNAJanssen's PR has been stale, I forked from his repo and am attempting to get it active again and hopefully merged in.

If there is anything missing or I need to do more, please let me know as I'm new to this.

@carabasdaniel
Copy link
Copy Markdown
Contributor

Hi @Spuffnduff,

This looks good, but would it be possible to add some tests to verify that this is working as intended and maybe squash the commits ?

Once that's done I'll close #1154 and get this merged.

Thanks.

@Spuffnduff
Copy link
Copy Markdown
Contributor Author

I'll look into squashing the commits. I may need some help in writing some tests but will reach out when the time comes.

@lionce
Copy link
Copy Markdown
Contributor

lionce commented Nov 7, 2019

Hello @Spuffnduff ,

Please let us know if we can help you! Thank you!

Cheers

@Spuffnduff Spuffnduff requested a review from a team as a code owner December 10, 2019 16:16
TNAJanssen and others added 3 commits December 10, 2019 11:29
Update xtrabackup.sh.erb
Updated the backupcompress comment in the backup main profile
@Spuffnduff
Copy link
Copy Markdown
Contributor Author

I think I performed enough squash cleanup for this PR. I noticed that there is a Travis test against this so it should rerun soon. If not I will look into it.

@Spuffnduff
Copy link
Copy Markdown
Contributor Author

Looking at the current .travis.yml file in my branch, it passes expect for Puppet v.4 which shouldn't matter. The current travis tests don't have that incorporated anymore (looking at the current master branch).

@carabasdaniel carabasdaniel merged commit d6c0a08 into puppetlabs:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants