(MODULES-1550) add new Feature MySQL login paths by andreas-stuerz · Pull Request #1295 · puppetlabs/puppetlabs-mysql

andreas-stuerz · 2020-04-02T08:00:44Z

https://tickets.puppetlabs.com/browse/MODULES-1550

…Server > 5.6.6

sheenaajay · 2020-04-14T09:14:17Z

Thanks @Andeman for submitting the PR. Thanks for the detailed information on the ticket too. Good Work.

sheenaajay · 2020-04-21T16:57:40Z

 * `mysql::server::config`: Private class for MySQL server configuration.
 * `mysql::server::install`: Private class for managing MySQL package.
 * `mysql::server::installdb`: Builds initial databases on installation.
+* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install


Suggested change

* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install

* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install.

sheenaajay · 2020-04-21T17:08:27Z

@@ -0,0 +1,9 @@
+#!/bin/sh


can we remove the scripts since all the test setup will be specified in the travis.yml file?

sheenaajay · 2020-04-21T17:09:54Z

@@ -0,0 +1,2 @@
+#!/bin/sh


can we remove the scripts folder since we have test setups and tear down specified in travis.yml file.?

sheenaajay · 2020-04-21T17:19:55Z

@@ -0,0 +1,92 @@
+# frozen_string_literal: true


Thanks for adding unit tests and acceptance tests. Will run them against release checks to verify on other OSes too. Thank you

pdksync - Add dependency gems to development group

There's been a properly namespaced modern `mysql::password` function for some time. See #1044 When the modern API non-namespaced shim was removed in a68004c the `puppet/parser/functions` version still existed so users who hadn't migrated to `mysql::password` would have reverted to this legacy API version. This commit finally removes the legacy version, but puts back the shim for now (to not create a breaking change just yet). Both namespaced and non-namespaced shim are tested.

Revert "Puppet 4 functions"

…d_function Remove legacy (old API) `mysql_password` function

* fix xtrabackup target directory and related regressions * fix handling of incremental backups with xtrabackup * MODULES-10023 add parameter $incremental_backups to parent class * MODULES-10023 add acceptance tests for xtrabackup * MODULES-10023 add xtrabackup documentation * MODULES-10023 fix acceptance tests * MODULES-10023 fix xtrabackup tests on CentOS 6 * MODULES-10023 fix xtrabackup tests on Debian 8, Ubuntu 14.04, Scientific 6 * MODULES-10023 fix xtrabackup tests on SLES, RHEL 8 and RHEL/CentOS 5 * MODULES-10023 fix xtrabackup tests on RHEL/CentOS 5 * MODULES-10023 disable new xtrabackup tests on EOL operating systems * (maint) exclude oracle6/centos6 platforms on running the feature tests Co-authored-by: David Swan <david.swan@puppet.co.uk> Co-authored-by: sheena <sheena@puppet.com>

Co-authored-by: Auto-release <team-modules@puppet.com>

This makes it easier for other modules also trying to manage the 'cron' package not to conflict.

pdksync - (maint) - Pdk Update

pdksync - Use abs instead of vmpooler to provision test resources

Use ensure_packages() to install the cron packages

sheenaajay · 2020-05-20T08:22:28Z

@Andeman Could you please rebase with latest master. I am rerunning them on all OSes. Thank you.

…Server > 5.6.6

# Conflicts: # Gemfile # metadata.json

codecov-commenter · 2020-05-26T07:21:30Z

Codecov Report

❗ No coverage uploaded for pull request base (master@fff2c82). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1295   +/-   ##
=========================================
  Coverage          ?   50.23%           
=========================================
  Files             ?       22           
  Lines             ?     1045           
  Branches          ?        0           
=========================================
  Hits              ?      525           
  Misses            ?      520           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff2c82...0bbe3fe. Read the comment docs.

sheenaajay · 2020-05-27T09:25:48Z

sheenaajay · 2020-05-27T09:26:11Z

Thanks alot for your contribution @Andeman Great Work.

djholms · 2020-06-04T13:20:14Z

Hello @Andeman and Team,
I faced with issue using this feature.

$root_pw = 'password'
mysql_login_path { 'client':
  password => Sensitive($root_pw), 
}

I got following error (only with this module):

Error: Transaction store file /opt/puppetlabs/puppet/cache/state/transactionstore.yaml is corrupt ((/opt/puppetlabs/puppet/cache/state/transactionstore.yaml): Tried to load unspecified class: Puppet::Provider::MysqlLoginPath::Sensitive); replacing
Wrapped exception:
Tried to load unspecified class: Puppet::Provider::MysqlLoginPath::Sensitive

Before using this feature I didn't face this error.
Thanks for Your support

alexjfisher · 2020-08-10T18:53:26Z

+Style/BracesAroundHashParameters:
+  Description: Braces are required by Ruby 2.7. Cop removed from RuboCop v0.80.0.
+    See https://github.com/rubocop-hq/rubocop/pull/7643
+  Enabled: true


Is this right?? Seems to directly contradict the change made in PDK.
puppetlabs/pdk-templates#329

Ignore this comment. It doesn't relate to this PR. Rebasing/merging must have gone a bit funny at some point to pull this in here.

(MODULES-1550) add new Feature MySQL login paths for Mysql Community …

c09a1ae

…Server > 5.6.6

andreas-stuerz requested a review from a team as a code owner April 2, 2020 08:00

fraenki mentioned this pull request Apr 6, 2020

Security concern on calling /usr/local/bin/clustercheck markt-de/puppet-galera#96

Open

sheenaajay added the feature label Apr 21, 2020

sheenaajay reviewed Apr 21, 2020

View reviewed changes

Andreas Stuerz and others added 19 commits April 22, 2020 09:26

(MODULES-1550) remove scripts directory

a6f8c92

(MODULES-1550) add full stop to summary

bf768e9

Add net-ssh dependency gems to development group

5fa3556

Merge pull request #1297 from puppetlabs/pdksync_dependency_gems_update

0a8f005

pdksync - Add dependency gems to development group

Revert "Puppet 4 functions"

11abd6a

Merge pull request #1298 from alexjfisher/revert-1274-puppet_4_functions

dd49fdd

Revert "Puppet 4 functions"

Merge pull request #1299 from alexjfisher/remove_legacy_mysql_passwor…

39b7bde

…d_function Remove legacy (old API) `mysql_password` function

(maint) - Pdk Update

6a7347b

(maint) - add back gems removed by pdk update

d6c5363

Release version 10.5.0 (#1301)

7f9bf78

Co-authored-by: Auto-release <team-modules@puppet.com>

Manage the 'cron' package using ensure_package()

b03fc2c

This makes it easier for other modules also trying to manage the 'cron' package not to conflict.

Merge pull request #1300 from puppetlabs/pdksync_PDK_UPDATE

7eab9e4

pdksync - (maint) - Pdk Update

Change provision from vmpooler to abs

3610f44

Switch to default spec_helper_acceptance file

d49e874

Update spec_helper_acceptance_local.rb

f7b93a0

Merge pull request #1302 from puppetlabs/pdksync_abs

1529f91

pdksync - Use abs instead of vmpooler to provision test resources

Merge pull request #1269 from baldurmen/no_cron

4a056a8

Use ensure_packages() to install the cron packages

andreas-stuerz and others added 4 commits May 26, 2020 08:33

(MODULES-1550) add new Feature MySQL login paths for Mysql Community …

9722116

…Server > 5.6.6

(MODULES-1550) remove scripts directory

c076179

(MODULES-1550) add full stop to summary

1592186

Merge remote-tracking branch 'origin/master'

0bbe3fe

# Conflicts: # Gemfile # metadata.json

sheenaajay merged commit 23f89af into puppetlabs:master May 27, 2020

alexjfisher reviewed Aug 10, 2020

View reviewed changes

gcoxmoz mentioned this pull request Dec 29, 2023

puppetlabs-mysql contains linux binaries #1613

Open

	* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install
	* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install.

Conversation

andreas-stuerz commented Apr 2, 2020

Uh oh!

sheenaajay commented Apr 14, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sheenaajay commented May 20, 2020

Uh oh!

codecov-commenter commented May 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sheenaajay commented May 27, 2020

Uh oh!

sheenaajay commented May 27, 2020

Uh oh!

djholms commented Jun 4, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov-commenter commented May 26, 2020 •

edited

Loading