Support compression command and extension

[dploeger]

This makes it possible to configure the previously hardcoded bzip2 compression and use a faster or parallel compression. It doesn't support package installation for other compression commands.

[puppet-community-rangefinder]

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::server::backup is a class

Breaking changes to this file WILL impact these 4 modules (exact match):

• thbe-bacula
• thbe-bareos
• mightp-librenms
• dmcnicks-sympa

This module is declared in 143 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[dploeger]

I currently can't sign the CLA (it seems you're using a wrong return URL for the Github auth).

Also, I didn't know how to update reference documentation as rake strings:generate produces:

rake aborted!
Errno::EISDIR: Is a directory @ io_fread - readmes
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/yard-0.9.26/lib/yard/code_objects/extra_file_object.rb:77:in `read'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/yard-0.9.26/lib/yard/code_objects/extra_file_object.rb:77:in `ensure_parsed'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/yard-0.9.26/lib/yard/code_objects/extra_file_object.rb:25:in `initialize'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/yard-0.9.26/lib/yard/cli/yardoc.rb:300:in `new'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/yard-0.9.26/lib/yard/cli/yardoc.rb:300:in `parse_arguments'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/yard-0.9.26/lib/yard/cli/yardoc.rb:248:in `run'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/yard-0.9.26/lib/yard/cli/command.rb:14:in `run'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/puppet-strings-2.6.0/lib/puppet-strings.rb:55:in `generate'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/puppet-strings-2.6.0/lib/puppet-strings/tasks/generate.rb:45:in `block (2 levels) in <top (required)>'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/honeycomb-beeline-2.4.0/lib/honeycomb/integrations/rake.rb:21:in `block in execute'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/honeycomb-beeline-2.4.0/lib/honeycomb/client.rb:70:in `start_span'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/honeycomb-beeline-2.4.0/lib/honeycomb/integrations/rake.rb:16:in `execute'
/Users/dennis.ploeger/code/puppet/forks/puppetlabs-mysql/vendor/cache/ruby/2.7.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
Tasks: TOP => strings:generate
(See full trace by running task with --trace)

[codecov-io]

Codecov Report

Merging #1363 (c09f03f) into main (7acb8b5) will increase coverage by 5.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
+ Coverage   50.33%   55.66%   +5.32%     
==========================================
  Files          22       22              
  Lines        1055     1051       -4     
==========================================
+ Hits          531      585      +54     
+ Misses        524      466      -58     

Impacted Files	Coverage Δ
lib/puppet/provider/mysql_user/mysql.rb	87.41% <0.00%> (-0.18%)	⬇️
lib/puppet/type/mysql_login_path.rb	100.00% <0.00%> (ø)
lib/puppet/provider/mysql_grant/mysql.rb	16.66% <0.00%> (+0.17%)	⬆️
...ppet/provider/mysql_login_path/mysql_login_path.rb	90.72% <0.00%> (+58.76%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28bddab...c09f03f. Read the comment docs.

[david22swan]

Taking a quick look these seem like good changes to have in the code.
Just one small comment but otherwise I think it all looks good and would be happy to merge.

Thanks for putting in the work :)

[david22swan]

@dploeger Thanks for getting back so fast with the change. Everything looks good to me so I've gone ahead and merged it.
Once again, thanks for putting in the work.

[dploeger]

@david22swan Awesome! Thanks a lot. Do you know when the next version that will include this fix is due?

[david22swan]

@dploeger A release of the module just went out so it might be a while, mysql releases are fairly common however so it shouldn't be too long.