(maint) Update sync.yaml for new modsync config options#208
Merged
michaeltlombardi merged 2 commits intopuppetlabs:masterfrom Feb 12, 2018
Merged
(maint) Update sync.yaml for new modsync config options#208michaeltlombardi merged 2 commits intopuppetlabs:masterfrom
michaeltlombardi merged 2 commits intopuppetlabs:masterfrom
Conversation
Previously the travis.yaml file was unmanaged as it contained customisations not compatible with modsync. Now that the required options are available the sync file can be updated accordingly. This commit: - Updates the sudo, dist and before_install commands to install Powershell - Updates the NOTICE file to indicate the correct dates for the copyright holders
Contributor
Author
|
Travis.yaml is to remain unmanaged until puppetlabs/modulesync_configs#178 is merged |
michaeltlombardi
approved these changes
Jan 12, 2018
Contributor
|
@glennsarti changes look fine, puppetlabs/modulesync_configs#178 is merged |
glennsarti
changed the title
This commit applies modsync at commit a3ae5c94f7d
| platforms: ["mswin", "mingw", "x64_mingw"] | ||
| version: '< 2.6.0' | ||
| .travis.yml: | ||
| unmanaged: true |
Contributor
There was a problem hiding this comment.
So this file's now unmanaged but we're adding settings for it?
Contributor
Author
There was a problem hiding this comment.
Correct. We are now managing this file with the specified settings.
michaeltlombardi
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the travis.yaml file was unmanaged as it contained customisations not
compatible with modsync. Now that the required options are available the sync
file can be updated accordingly. This commit:
holders