Skip to content

add missing param manage_firewall#160

Merged
kbarber merged 1 commit intopuppetlabs:masterfrom
bastelfreak:fix-manage-firewall
Jan 7, 2015
Merged

add missing param manage_firewall#160
kbarber merged 1 commit intopuppetlabs:masterfrom
bastelfreak:fix-manage-firewall

Conversation

@bastelfreak
Copy link
Copy Markdown
Collaborator

the param manage_firewall was added in an earlier release to puppetdb::server. The class isn't called directly but via the init.pp. the puppetdb class had already the param manage_firewall but this wasn't forwarded to puppetdb::server

the param manage_firewall was added in an earlier release to puppetdb::server. The class isn't called directly but via the init.pp. the puppetdb class had already the param manage_firewall but this wasn't forwarded to puppetdb::server
@ekohl
Copy link
Copy Markdown
Contributor

ekohl commented Jan 5, 2015

I can see the parameter exists here:

$manage_firewall = $puppetdb::params::manage_firewall,

@ekohl
Copy link
Copy Markdown
Contributor

ekohl commented Jan 5, 2015

Disregard that, I misread it.

@electrical
Copy link
Copy Markdown

Test failure due to ruby dep issue: Gem::InstallError: i18n requires Ruby version >= 1.9.3. on the ruby 1.8.7 tests.

@bastelfreak
Copy link
Copy Markdown
Collaborator Author

@electrical I guess this issue has nothing to do with the modified code and should be fixed in another PR?

@electrical
Copy link
Copy Markdown

@bastelfreak yeah indeed. its unrelated to your change.

kbarber added a commit that referenced this pull request Jan 7, 2015
@kbarber kbarber merged commit cb71baa into puppetlabs:master Jan 7, 2015
@bastelfreak bastelfreak deleted the fix-manage-firewall branch June 10, 2018 19:50
@smortex smortex added the bugfix label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants