(PDB-1035) Add default PuppetDB root context#181
Conversation
ajroetker
force-pushed
the
ticket/pdb-1485/master/add_pdb_root_context_for_query_api
branch
5 times, most recently
from
50da3ba to
6e090a7
Compare
There was a problem hiding this comment.
Not crititcal, but I might be tempted to leave out the whitespace changes or put them in a separate patch so that this one is focused on the /pdb/query changes.
There was a problem hiding this comment.
This is more like a clojure formatting anyway, not ruby. I'd stay with what we had TBH, its more idiomatic.
There was a problem hiding this comment.
Meh, we're guilty of clojure like formatting throughout all this code anyway. Lol.
|
@ajroetker I think this patch needs docs updates calling out how to use the old terminus name, and the old test url if one is still on the old version of PDB. Since users who have just used ensure => installed, won't be able to get the benefits of your auto-detection, and may still be using PDB 2.3.x. |
|
This duplicates the work here: https://tickets.puppetlabs.com/browse/PDB-1035 |
|
@ajroetker this still needs doc updates. |
|
@kbarber I know I was waiting for the the version/cmd patch because this will have to change again after that goes in |
|
@ajroetker okay, makes sense. |
ajroetker
force-pushed
the
ticket/pdb-1485/master/add_pdb_root_context_for_query_api
branch
from
6e090a7 to
b9be30a
Compare
ajroetker
changed the title
There was a problem hiding this comment.
v3/version is still mentioned a number of times in this file
This commit changes the terminus configuration to use the new root prefix for PuppetDB and changes the connection validator to do the same. This commit also adds the terminus package name changes `terminus` to `termini` and tries to be smart about the default, checking to see what version of PuppetDB was passed in and defaulting off of that value.
ajroetker
force-pushed
the
ticket/pdb-1485/master/add_pdb_root_context_for_query_api
branch
from
b9be30a to
829626f
Compare
…_root_context_for_query_api (PDB-1035) Add default PuppetDB root context
6 participants
This commit changes the terminus configuration to use the new root
prefix for PuppetDB and changes the connection validator to do the same.